Adds Scalyr Logging Endpoint Support #252
Conversation
|
Force-pushed two squashed commits that make the Token field required. |
|
|
||
| "token": { | ||
| Type: schema.TypeString, | ||
| Required: true, |
There was a problem hiding this comment.
The docs don't say required, but it's required in the CLI and confirmed that this is required by the backend.
Also noted that the docs need to be updated.
|
Force-pushed a squashed commit that fixed a grammar error in the docs and renames variables using 'h'. |
|
TODO: add logging_scalyr to this block - https://github.com/terraform-providers/terraform-provider-fastly/pull/252/files#diff-e11f97f0c242e77100f2f794b0ac08abR1578 |
|
Force-pushed a squashed commit addressing self-review comments. |
|
Force-pushed a squashed commit addressing more self-review comments. |
fastly/resource_fastly_service_v1.go
Outdated
| if err := readScalyr(conn, d, s); err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
I'm interested, your other PR's for new endpoints haven't included this read. If correct we should fix in the others.
There was a problem hiding this comment.
Absolutely! I think they should now. I will confirm.
|
Force-pushed squashing into a single commit. |
|
Force-pushed rebasing master. |
Signed-off-by: Colton J. McCurdy <cmccurdy@fastly.com>
Proposed Changes
Relevant Link(s) / Documentation
Validation
export FASTLY_API_KEY=foo; export TF_ACC=1; make testacccc @phamann @ezkl