Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing server_side_encryption and server_side_encryption_kms_… #246

Merged
merged 3 commits into from
Jun 3, 2020
Merged

Adding missing server_side_encryption and server_side_encryption_kms_… #246

merged 3 commits into from
Jun 3, 2020

Conversation

cparmar
Copy link

@cparmar cparmar commented Jun 3, 2020

…key_id parameters to S3 configuration written to state.

Fix for issue #225

@ghost ghost added the size/S label Jun 3, 2020
@phamann phamann self-requested a review June 3, 2020 15:02
Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you for the contribution @cparmar, I must apologise for dropping the ball on this one in the issue discussion. I appreciate you contributing the fix.

@phamann phamann merged commit 0250d69 into fastly:master Jun 3, 2020
@phamann
Copy link
Member

phamann commented Jun 3, 2020

@cparmar This was released in v0.16.1

@cparmar cparmar deleted the cparmar1/fix-s3-sse-params branch June 3, 2020 18:41
@cparmar
Copy link
Author

cparmar commented Jun 3, 2020

Thanks @phamann! I can confirm the fix worked and we now have expected behaviour:

No changes. Infrastructure is up-to-date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants