-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for FTP logging #235
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,264 @@ | ||
package fastly | ||
|
||
import ( | ||
"fmt" | ||
"log" | ||
|
||
gofastly "github.com/fastly/go-fastly/fastly" | ||
"github.com/hashicorp/terraform-plugin-sdk/helper/schema" | ||
) | ||
|
||
var ftpSchema = &schema.Schema{ | ||
Type: schema.TypeSet, | ||
Optional: true, | ||
Elem: &schema.Resource{ | ||
Schema: map[string]*schema.Schema{ | ||
// Required fields | ||
"name": { | ||
Type: schema.TypeString, | ||
Required: true, | ||
Description: "The unique name of the FTP logging endpoint.", | ||
}, | ||
|
||
"address": { | ||
Type: schema.TypeString, | ||
Required: true, | ||
Description: "The FTP URL to stream logs to.", | ||
}, | ||
|
||
"user": { | ||
Type: schema.TypeString, | ||
Required: true, | ||
Description: "The username for the server (can be anonymous).", | ||
}, | ||
|
||
"password": { | ||
Type: schema.TypeString, | ||
Required: true, | ||
Description: "The password for the server (for anonymous use an email address).", | ||
Sensitive: true, | ||
}, | ||
|
||
"path": { | ||
Type: schema.TypeString, | ||
Required: true, | ||
Description: "The path to upload log files to. If the path ends in / then it is treated as a directory.", | ||
}, | ||
|
||
// Optional fields | ||
"port": { | ||
Type: schema.TypeInt, | ||
Optional: true, | ||
Default: 21, | ||
Description: "The port number.", | ||
}, | ||
|
||
"period": { | ||
Type: schema.TypeInt, | ||
Optional: true, | ||
Default: 3600, | ||
Description: "How frequently the logs should be transferred, in seconds (Default 3600).", | ||
}, | ||
|
||
"public_key": { | ||
Type: schema.TypeString, | ||
Optional: true, | ||
Description: "The PGP public key that Fastly will use to encrypt your log files before writing them to disk.", | ||
}, | ||
|
||
"gzip_level": { | ||
Type: schema.TypeInt, | ||
Optional: true, | ||
Default: 0, | ||
Description: "Gzip Compression level.", | ||
}, | ||
|
||
"timestamp_format": { | ||
Type: schema.TypeString, | ||
Optional: true, | ||
Default: "%Y-%m-%dT%H:%M:%S.000", | ||
Description: "specified timestamp formatting (default `%Y-%m-%dT%H:%M:%S.000`).", | ||
}, | ||
|
||
"format": { | ||
Type: schema.TypeString, | ||
Optional: true, | ||
Description: "Apache-style string or VCL variables to use for log formatting.", | ||
}, | ||
|
||
"format_version": { | ||
Type: schema.TypeInt, | ||
Optional: true, | ||
Default: 2, | ||
Description: "The version of the custom logging format used for the configured endpoint. Can be either 1 or 2. (default: 2).", | ||
ValidateFunc: validateLoggingFormatVersion(), | ||
}, | ||
|
||
"placement": { | ||
Type: schema.TypeString, | ||
Optional: true, | ||
Description: "Where in the generated VCL the logging call should be placed.", | ||
ValidateFunc: validateLoggingPlacement(), | ||
}, | ||
|
||
"response_condition": { | ||
Type: schema.TypeString, | ||
Optional: true, | ||
Description: "The name of the condition to apply.", | ||
}, | ||
}, | ||
}, | ||
} | ||
|
||
func processFTP(d *schema.ResourceData, conn *gofastly.Client, latestVersion int) error { | ||
serviceID := d.Id() | ||
of, nf := d.GetChange("logging_ftp") | ||
|
||
if of == nil { | ||
of = new(schema.Set) | ||
} | ||
if nf == nil { | ||
nf = new(schema.Set) | ||
} | ||
|
||
ofs := of.(*schema.Set) | ||
nfs := nf.(*schema.Set) | ||
|
||
removeFTPLogging := ofs.Difference(nfs).List() | ||
addFTPLogging := nfs.Difference(ofs).List() | ||
|
||
// DELETE old FTP logging endpoints. | ||
for _, oRaw := range removeFTPLogging { | ||
of := oRaw.(map[string]interface{}) | ||
opts := buildDeleteFTP(of, serviceID, latestVersion) | ||
|
||
log.Printf("[DEBUG] Fastly FTP logging endpoint removal opts: %#v", opts) | ||
|
||
if err := deleteFTP(conn, opts); err != nil { | ||
return err | ||
} | ||
} | ||
|
||
// POST new/updated FTP logging endpoints. | ||
for _, nRaw := range addFTPLogging { | ||
ef := nRaw.(map[string]interface{}) | ||
opts := buildCreateFTP(ef, serviceID, latestVersion) | ||
|
||
log.Printf("[DEBUG] Fastly FTP logging addition opts: %#v", opts) | ||
|
||
if err := createFTP(conn, opts); err != nil { | ||
return err | ||
} | ||
} | ||
|
||
return nil | ||
} | ||
|
||
func readFTP(conn *gofastly.Client, d *schema.ResourceData, s *gofastly.ServiceDetail) error { | ||
// Refresh FTP. | ||
log.Printf("[DEBUG] Refreshing FTP logging endpoints for (%s)", d.Id()) | ||
ftpList, err := conn.ListFTPs(&gofastly.ListFTPsInput{ | ||
Service: d.Id(), | ||
Version: s.ActiveVersion.Number, | ||
}) | ||
|
||
if err != nil { | ||
return fmt.Errorf("[ERR] Error looking up FTP logging endpoints for (%s), version (%v): %s", d.Id(), s.ActiveVersion.Number, err) | ||
} | ||
|
||
ell := flattenFTP(ftpList) | ||
|
||
if err := d.Set("logging_ftp", ell); err != nil { | ||
log.Printf("[WARN] Error setting FTP logging endpoints for (%s): %s", d.Id(), err) | ||
} | ||
|
||
return nil | ||
} | ||
|
||
func createFTP(conn *gofastly.Client, i *gofastly.CreateFTPInput) error { | ||
_, err := conn.CreateFTP(i) | ||
return err | ||
} | ||
|
||
func deleteFTP(conn *gofastly.Client, i *gofastly.DeleteFTPInput) error { | ||
err := conn.DeleteFTP(i) | ||
errRes, ok := err.(*gofastly.HTTPError) | ||
if !ok { | ||
return err | ||
} | ||
|
||
// 404 response codes don't result in an error propagating because a 404 could | ||
// indicate that a resource was deleted elsewhere. | ||
if !errRes.IsNotFound() { | ||
return err | ||
} | ||
|
||
return nil | ||
} | ||
|
||
func flattenFTP(ftpList []*gofastly.FTP) []map[string]interface{} { | ||
var fsl []map[string]interface{} | ||
for _, fl := range ftpList { | ||
// Convert FTP logging to a map for saving to state. | ||
nfl := map[string]interface{}{ | ||
"name": fl.Name, | ||
"address": fl.Address, | ||
"user": fl.Username, | ||
"password": fl.Password, | ||
"path": fl.Path, | ||
"port": fl.Port, | ||
"period": fl.Period, | ||
"public_key": fl.PublicKey, | ||
"gzip_level": fl.GzipLevel, | ||
"timestamp_format": fl.TimestampFormat, | ||
"format": fl.Format, | ||
"format_version": fl.FormatVersion, | ||
"placement": fl.Placement, | ||
"response_condition": fl.ResponseCondition, | ||
} | ||
|
||
// Prune any empty values that come from the default string value in structs. | ||
for k, v := range nfl { | ||
if v == "" { | ||
delete(nfl, k) | ||
} | ||
} | ||
|
||
fsl = append(fsl, nfl) | ||
} | ||
|
||
return fsl | ||
} | ||
|
||
func buildCreateFTP(ftpMap interface{}, serviceID string, serviceVersion int) *gofastly.CreateFTPInput { | ||
df := ftpMap.(map[string]interface{}) | ||
|
||
return &gofastly.CreateFTPInput{ | ||
Service: serviceID, | ||
Version: serviceVersion, | ||
Name: df["name"].(string), | ||
Address: df["address"].(string), | ||
Username: df["user"].(string), | ||
Password: df["password"].(string), | ||
Path: df["path"].(string), | ||
Port: uint(df["port"].(int)), | ||
Period: uint(df["period"].(int)), | ||
PublicKey: df["public_key"].(string), | ||
GzipLevel: uint8(df["gzip_level"].(int)), | ||
TimestampFormat: df["timestamp_format"].(string), | ||
Format: df["format"].(string), | ||
FormatVersion: uint(df["format_version"].(int)), | ||
Placement: df["placement"].(string), | ||
ResponseCondition: df["response_condition"].(string), | ||
} | ||
} | ||
|
||
func buildDeleteFTP(ftpMap interface{}, serviceID string, serviceVersion int) *gofastly.DeleteFTPInput { | ||
df := ftpMap.(map[string]interface{}) | ||
|
||
return &gofastly.DeleteFTPInput{ | ||
Service: serviceID, | ||
Version: serviceVersion, | ||
Name: df["name"].(string), | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just making note that for FTP we don't explicitly expose IPV4 or Hostname because Address includes these values.
https://developer.fastly.com/reference/api/logging/ftp/