Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same domain for all acceptance tests #212

Merged
merged 3 commits into from
Mar 26, 2020

Conversation

philippschulte
Copy link
Member

The acceptance tests of fastly/resource_fastly_service_v1_syslog_test.go are currently failing:

=== RUN   TestAccFastlyServiceV1_syslog_basic
--- FAIL: TestAccFastlyServiceV1_syslog_basic (3.58s)
    testing.go:569: Step 0 error: errors during apply:

        Error: 400 - Bad Request:

            Title:  Bad request
            Detail: Domain 'notadomain1.com' is already taken by another customer

          on /var/folders/n4/ggm3f3vn1wbcql74h1xqt0nr0000gn/T/tf-test305549885/main.tf line 2:
          (source code not available)


=== RUN   TestAccFastlyServiceV1_syslog_formatVersion
--- FAIL: TestAccFastlyServiceV1_syslog_formatVersion (3.17s)
    testing.go:569: Step 0 error: errors during apply:

        Error: 400 - Bad Request:

            Title:  Bad request
            Detail: Domain 'notadomain1.com' is already taken by another customer

          on /var/folders/n4/ggm3f3vn1wbcql74h1xqt0nr0000gn/T/tf-test259495287/main.tf line 2:
          (source code not available)


=== RUN   TestAccFastlyServiceV1_syslog_useTls
--- FAIL: TestAccFastlyServiceV1_syslog_useTls (3.72s)
    testing.go:569: Step 0 error: errors during apply:

        Error: 400 - Bad Request:

            Title:  Bad request
            Detail: Domain 'notadomain1.com' is already taken by another customer

          on /var/folders/n4/ggm3f3vn1wbcql74h1xqt0nr0000gn/T/tf-test063435457/main.tf line 2:
          (source code not available)

This PR aligns the domain "fastly-test.tf-%s.com" to all acceptance tests. After this PR is merged all acceptance tests use the same domain so that it can be easily replaced if it is used by another user again.

@ghost ghost added the size/XS label Mar 26, 2020
@philippschulte philippschulte changed the title Use the same domain in all acceptance tests Use the same domain for all acceptance tests Mar 26, 2020
Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philippschulte philippschulte merged commit c83a302 into master Mar 26, 2020
@philippschulte philippschulte deleted the pschulte/update-domains-of-integration-tests branch March 26, 2020 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants