Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gofastly library in ip ranges data source #201

Merged

Conversation

0x91
Copy link
Contributor

@0x91 0x91 commented Dec 12, 2019

This PR changes the IP addresses data source to consume from the gofastly library instead of calling the endpoint directly.

This change is needed because the current implementation does not handle HTTP Errors received from the Fastly API. This caused a production outage for us a week ago when the Fastly API returned 503, and the data source did not return an error.

This change brings this part of the provider in line with the rest of the codebase, which already uses the gofastly library.

@ghost ghost added the size/XS label Dec 12, 2019
Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this @0x91, sorry to hear the provider caused an outage.

LGTM 👍 - we'll get this merged and released and will let you know once done.

Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0x91 thanks for your contribution! I hope that Hashicorp will cut a new release on Monday. We'll keep you updated as @phamann already mentioned.

@philippschulte philippschulte merged commit e8343df into fastly:master Dec 13, 2019
@philippschulte
Copy link
Member

@0x91, @rymir just wanted to let you know that Hashicorp cut a new release of the Fastly provider today: https://github.com/terraform-providers/terraform-provider-fastly/blob/master/CHANGELOG.md#0111-december-16-2019. Thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants