Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few missing fields to some API's #86

Merged
merged 1 commit into from
Sep 12, 2018

Conversation

hynd
Copy link
Contributor

@hynd hynd commented Sep 12, 2018

  • The CreateDirectorInput and UpdateDirectorInput were missing the
    capacity field, added the shield field.

  • Added name (NewName) to UpdateDirectorInput, UpdateConditionInput

  • Added write_only bool to CreateDictionary/UpdateDictionary

  • Added comment to various, and created_at/deleted_at/updated_at to
    those that support it (eg; those that can be updated dynamically).

  • Removed locked from Domain (looks like a copypasta from elsewhere?)

* The CreateDirectorInput and UpdateDirectorInput were missing the
`capacity` field, added the `shield` field.

* Added `name` (NewName) to UpdateDirectorInput, UpdateConditionInput

* Added `write_only` bool to CreateDictionary/UpdateDictionary

* Added `comment` to various, and created_at/deleted_at/updated_at to
  those that support it (eg; those that can be updated dynamically).

* Removed `locked` from Domain (looks like a copypasta from elsewhere?)
@hynd
Copy link
Contributor Author

hynd commented Sep 12, 2018

@sethvargo sethvargo merged commit 7d947bf into fastly:master Sep 12, 2018
@hynd hynd deleted the add_missing_fields branch September 13, 2018 07:09
@lock lock bot locked as resolved and limited conversation to collaborators Dec 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants