Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template code for fastly:0.2.0-alpha4 #7

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

cratelyn
Copy link
Contributor

@cratelyn cratelyn commented Apr 7, 2020

This PR does two small, but important things:

  • First, it updates the code in main.rs to account for changes in the guest API, most notably using the CacheOverride that was introduced in fastly/ExecuteD#175. These are unremarkable changes.
  • Most importantly, we also bump the version of our fastly dependency to the (unreleased) 0.2.0-alpha4-dev version that is currently on master in ExecuteD.

This is predicated on the work done in fastly/cli#14, and is the last hurdle before these templates can be added to the ExecuteD integration test suite (see fastly/ExecuteD#183).

As noted in 16fbaaa, our fastly version would be changed to 0.2.0-alpha4 once we release a new version of the API.

@cratelyn cratelyn requested review from phamann and acfoltzer and removed request for phamann and acfoltzer April 7, 2020 18:28
Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. Thank you!

@cratelyn cratelyn force-pushed the ktm/update-template-to-fastly-master branch from 4912370 to 34897de Compare April 8, 2020 14:55
@cratelyn cratelyn requested a review from phamann April 8, 2020 14:55
@cratelyn cratelyn changed the title Update template code for fastly:0.2.0-alpha4-dev Update template code for fastly:0.2.0-alpha4 Apr 8, 2020
@phamann phamann merged commit 14b5e8e into master Apr 8, 2020
@phamann phamann deleted the ktm/update-template-to-fastly-master branch April 8, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants