breaking(language.rust): Switch Rust builds to wasm32-wasip1 instead of wasm32-wasi #1382
+84
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5283bcd to
97ea81b
Compare
Integralist
previously approved these changes
Jan 30, 2025
|
LGTM, and I've approved the PR but we'll need either @kpfleming or @philippschulte to handle merging this PR and the subsequent new major release. |
philippschulte
previously approved these changes
Jan 30, 2025
b9a2a4c to
c7c0910
Compare
30cc440
30cc440 to
c7c0910
Compare
kpfleming
requested changes
Feb 6, 2025
3514cb3 to
cca0fc1
Compare
|
I updated the PR title to reflect the purpose of the change, since it will end up in the changelog. |
kpfleming
requested changes
Feb 7, 2025
| @@ -144,12 +147,17 @@ func (r *Rust) Dependencies() map[string]string { | |||
|
|
|||
| // Build compiles the user's source code into a Wasm binary. | |||
| func (r *Rust) Build() error { | |||
| var wasmWasiTarget = r.config.WasmWasiTarget | |||
| if wasmWasiTarget != RustWasmWasiTarget { | |||
| return fmt.Errorf("your .cargo/config.toml file is configured to produce a %s binary, but that is not supported. It must be configured to produce a %s binary", wasmWasiTarget, RustWasmWasiTarget) | |||
There was a problem hiding this comment.
It looks like I was mistaken here; the value r.config.WasmWasiTarget didn't come from .cargo/config.toml, but from ~/.config/fastly/config.toml (or the equivalent path on non-Linux systems). Please verify the behavior here, this error should be emitted when that file has the wrong value, not when .cargo/config.toml has the wrong value.
If this is true, we're going to need to add new checks to validate the content of .cargo/config.toml and rust-toolchain.toml as well.
78969e3 to
98b8839
Compare
…m32-wasi Breaking change to support Rust 1.84 and newer BREAKING CHANGE: Only the wasm32-waip1 build target is accepted if a non default config is provided
98b8839 to
bf30e4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change to support Rust 1.84 and newer
BREAKING CHANGE:
Only the wasm32-wasip1 build target is accepted if a non default config is provided
All Submissions:
New Feature Submissions:
Changes to Core Features:
Are there any considerations that need to be addressed for release?
this is a breaking change and will require a major version bump to prevent breakages