feat(npm): Properly handle error from npm-invoked cli #1302
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects the case when the
fastly
command exits with a non-zero exit code when called through the npm wrapper.Before this fix, the script doesn't run to completion, a stack trace leaks, and the real exit code is not available to the caller.
Example error output when called with non-existent
--asdf
flag:This happens because the exit code is 1. The wrapper invokes
fastly
using thechild_process.execFileSync()
function:This PR fixes this by:
execFileSync()
with atry
/catch
.err
object forcode
. If this is set then it meansexecFileSync()
itself failed (couldn't launch, timeout, etc.), so we rethrow the error.err
object forstatus
. If this is set then it means the child process has set an exit code, so we set the current process's exit code to the value.New output: