Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(npm): Add TypeScript types to @fastly/cli #1296

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

harmony7
Copy link
Member

This PR adds TypeScript types to the @fastly/cli package so that it can be imported into TypeScript programs.

import cli from '@fastly/cli';

const result = spawnSync(
  cli,
  [
    "version",
  ],
  {
    shell: true,
    encoding: "utf-8",
  }
);

Without these types, TypeScript will complain:

TS2306: File
/path/to/node_modules/@fastly/cli/index.d.ts
is not a module.

@harmony7 harmony7 requested review from kpfleming and kailan August 19, 2024 13:21
@kpfleming kpfleming changed the title Add TypeScript types to @fastly/cli feat(npm): Add TypeScript types to @fastly/cli Aug 20, 2024
@kpfleming kpfleming merged commit c62c0f8 into main Aug 20, 2024
9 checks passed
@kpfleming kpfleming deleted the kats/cli-ts-types branch August 20, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants