Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(update): Ensure that the CLI binary will be executable after an update #1244

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

kpfleming
Copy link
Contributor

When the downloaded CLI binary cannot be 'moved' into position (i.e. when it is located on a different filesystem from the target location), it is copied, but the permissions need to be set after the copy so that it will be executable.

Closes #1168.

…pdate

When the downloaded CLI binary cannot be 'moved' into position
(i.e. when it is located on a different filesystem from the target
location), it is copied, but the permissions need to be set after the
copy so that it will be executable.

Closes fastly#1168.
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, otherwise LGTM

@kpfleming kpfleming merged commit c2f28dc into fastly:main Jul 9, 2024
6 checks passed
@kpfleming kpfleming deleted the issue-1168 branch July 9, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fastly update does not make the new binary executable on Linux
2 participants