refactor: rename test function names #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
added a commit
that referenced
this pull request
Dec 11, 2023
Integralist
added a commit
that referenced
this pull request
Feb 5, 2024
Integralist
added a commit
that referenced
this pull request
Feb 6, 2024
* refactor: rename test function names (#1107) * fix: address go vet issues * fix: remove deprecated field * fix: reference changed field names * refactor(all): bump to go-fastly v9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago I started naming functions
TestCreateinstead of the more explicitTest<SomeResource>Createwhich I did because the package name already provided the context for what the test was creating.But what ended up happening was that the test output when there was an error didn't help in identifying which of many
TestCreatefunctions had failed. As this change wasn't even consistent across the whole code base, I've decided to go back to the original naming.