-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Implementation #1
Conversation
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can get rid of .npmignore
if it is an exact copy of .gitignore
, as NPM will fall back to using .gitignore
if no .npmignore
exists. See https://docs.npmjs.com/cli/v8/using-npm/developers#keeping-files-out-of-your-package
removed the .npmignore I still have to reactivate some unit tests and then it should be good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@Uzlopak I don't really agree with So, from version 8, if we don't want to expose the routes documentation in production, we must not register the plugin at all? |
Note that you need to write:
What would be a better option? |
@Eomm for me, the best option would be the one exposed by the exposeRoute flag. |
This is the first implementation of the swagger-ui plugin.
Only options which effect the exposeRoute and the swagger-ui from @fastify/swagger should be covered by this plugin. exposeRoute as an option was removed, as it is implied that we want to expose the routes if we use this plugin.
Let us talk about if the initial options and separation is fine.
Still have to fix some tests, but it should already be self explainatory.
So please let us discuss if it is meeting our needs.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct