Fix/multiple files in body #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR closes #64 I would like only to remind that, when we will define how to manage the behaviour of this fix, a note in the readme is needed 👍 |
|
@Eomm, yes, that's planned if others confirm that receiving array of files in any cases is acceptable behaviour or not. |
mcollina
reviewed
Apr 19, 2019
nwoltman
reviewed
Apr 20, 2019
mcollina
reviewed
Apr 20, 2019
added 2 commits
April 22, 2019 00:13
Eomm
approved these changes
Apr 21, 2019
mcollina
reviewed
May 20, 2019
nwoltman
reviewed
May 20, 2019
Co-Authored-By: Nathan Woltman <nwoltman@outlook.com>
add newline
nwoltman
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes from #63 so it should be merged first.
It currently makes behaviour slightly different, so file field will be an array by default, even if there's only one file. Please let me know if it's ok or not. And after that I'll update documentation accordingly.