Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use @fastify/busboy v2.1.0 #506

Merged
merged 2 commits into from
Jan 28, 2024
Merged

use @fastify/busboy v2.1.0 #506

merged 2 commits into from
Jan 28, 2024

Conversation

gurgunday
Copy link
Member

@gurgunday gurgunday commented Jan 24, 2024

Motivation: busboy@2 is more strict

For now it's not ideal (string comparison) but it works, maybe we can return a standard error message or error code from busboy, like 400

@gurgunday gurgunday requested a review from Uzlopak January 24, 2024 11:30
@Uzlopak Uzlopak changed the title use busboy2 use @fastify/busboy v2.1.0 Jan 24, 2024
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gurgunday gurgunday merged commit 8e4b5e5 into fastify:master Jan 28, 2024
19 checks passed
@gurgunday gurgunday deleted the busboy2 branch January 28, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants