Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat breaking: throw file size limit on toBuffer calls #265

Merged
merged 2 commits into from
Sep 14, 2021
Merged

feat breaking: throw file size limit on toBuffer calls #265

merged 2 commits into from
Sep 14, 2021

Conversation

Eomm
Copy link
Member

@Eomm Eomm commented Aug 10, 2021

Ref #263

Checklist

mcollina
mcollina approved these changes Aug 10, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I think this should be semver-major

@Eomm Eomm changed the title Throw file size limit on toBuffer calls feat breaking: throw file size limit on toBuffer calls Aug 12, 2021
@Eomm Eomm requested a review from a team September 14, 2021 07:53
zekth
zekth approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@zekth zekth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 on major

@Eomm Eomm merged commit a62116f into master Sep 14, 2021
@Eomm Eomm deleted the throwFileSizeLimit-toBuffer branch September 14, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@zekth zekth zekth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eomm @mcollina @zekth