Rename multipartIterator to parts #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibertoad
reviewed
Aug 27, 2020
| @@ -164,7 +164,12 @@ function fastifyMultipart (fastify, options = {}, done) { | |||
|
|
|||
| fastify.addContentTypeParser('multipart', setMultipart) | |||
| fastify.decorateRequest(kMultipartHandler, handleMultipart) | |||
|
|
|||
| fastify.decorateRequest('parts', getMultipartIterator) | |||
| // keeping multipartIterator to avoid bumping a major | |||
There was a problem hiding this comment.
wonder if this could be done by using some kind of getter that would be emitting warnings when used. although that might require support on fastify level
There was a problem hiding this comment.
maybe just a wrapping function would suffice here, actually
There was a problem hiding this comment.
This has been released for so little that I don't think we should bother with a full blown deprecation.
|
I'm not convinced about a rename at this stage but I'm also not against it. |
StarpTech
approved these changes
Aug 27, 2020
StarpTech
previously requested changes
Aug 27, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct