test: #5555 - move to node test runner #440

SamSalvatico · 2025-01-16T07:10:41Z

Checklist

Moving the tests from tap to the node test runner, based on what requested in the following issue
Fastify #5555

run npm run test and npm run benchmark
tests and/or benchmarks are included
documentation is changed or added
commit message and code follows the Developer's Certification of Origin
and the Code of conduct

SamSalvatico · 2025-01-17T18:21:23Z

I did not move all the tests yet, only the ones under commonjs and typescript esm
Just to understand if you like how I’ve moved the tests and to avoid modifying too many files in the same PR, I’ll make the next changes in a subsequent PR

test/commonjs/autohooks-basic.js

test/commonjs/error.js

test/typescript-esm/forceESM.ts

jean-michelet · 2025-01-17T18:52:22Z

Thanks for your PR.

I’ll make the next changes in a subsequent PR

This plugin is a bit tricky regarding testing, we might discover later then the changes are difficult to apply.
So imho, this PR should demonstrate if we can do it or not.
Plus, refactoring tests is generally very risky, as we don't have feedback about how the changes have affected the project so we might need some more reviews.

SamSalvatico · 2025-01-17T18:54:33Z

Thanks for your PR.

I’ll make the next changes in a subsequent PR

This plugin is a bit tricky regarding testing, we might discover later then the changes are difficult to apply. So imho, this PR should demonstrate if we can do it or not. Plus, refactoring tests is generally very risky, as we don't have feedback about how the changes have affected the project so we might need some more reviews.

Got it! So would you prefer that I try to update all the tests in this PR?

jean-michelet · 2025-01-17T18:56:33Z

So would you prefer that I try to update all the tests in this PR

I think it's a good idea, you might want some more reviews before going forward.

jean-michelet · 2025-01-17T18:57:01Z

@climba03003 @Fdawgs wdyt?

dancastillo · 2025-01-17T20:32:01Z

since t.assert.plan was not added until node v22 wondering if we should use tspl or something similar, wdyt? @mcollina @gurgunday

climba03003 · 2025-01-18T07:58:31Z

I think it's a good idea, you might want some more reviews before going forward.

I believe we can do incremental one, but it should be green before land.

since t.assert.plan was not added until node v22 wondering if we should use tspl or something similar, wdyt?

If you were mentioning t.plan, it exists since 20.15.0.

SamSalvatico · 2025-01-20T07:38:06Z

I should have changed all the tests from tap to node test runner (at least searching for tap there are no occurences 😁 )

SamSalvatico · 2025-01-20T16:10:02Z

scripts/unit.js

I am having some problems running tests using patterns, because windows is not managing them automatically
Before, when using tap, I think it was using the glob on which the library depends

I tried using the glob library by myself, but it failed.
The last idea I have is trying with fast-glob, but if it doesn't work I have to ask: do you have any clue about this?

I tried using the glob library by myself, but it failed.

The link you are sharing is not a failure, this test suite has been cancelled because the Node 20 on latest MacOS failed: https://github.com/fastify/fastify-autoload/actions/runs/12870529340/job/35882162556

"Exceeded timeout of 30000 ms for a test.

This is a timeout failure we had for a long time with Jest, I am not even sure we fixed it since.

See fastify/avvio#302

jean-michelet · 2025-01-21T08:37:58Z

I will perform a more precise review during the day before accepting, but looks good.

mcollina

lgtm

jean-michelet · 2025-01-23T13:15:48Z

Could be a good idea to use a LLM to check this diff, to be sure we didn't miss anything.

jean-michelet · 2025-01-24T09:23:03Z

@jsumners

Curious about the laugh emoji, I had a good experience with LLM catching omissions while refactoring.
Pretty bad at understanding complex context, but this case appear legit to me.

jsumners · 2025-01-24T11:37:15Z

@jsumners

Curious about the laugh emoji, I had a good experience with LLM catching omissions while refactoring. Pretty bad at understanding complex context, but this case appear legit to me.

I have zero confidence those things will provide anything useful, particularly in this context.

jean-michelet · 2025-01-24T12:19:04Z

I have zero confidence those things will provide anything useful

Strong opinion if you think this about programming more broadly (I do not suggest using it for Fastify projects in general).

@climba03003
Do you think we can merge?

jean-michelet · 2025-01-26T11:57:15Z

My bad, forget my previous comment.

scripts/unit.js

jean-michelet · 2025-01-26T12:18:41Z

scripts/unit.js

+  ...globSync('test/module/*.js'),
+]
+
+const args = ['node', '--test', ...testFiles]


We should use borp here @jsumners?

This project already has a scripts/ directory and uses them for running tests. I assume it's due to the way the module works. I don't really know; I don't pay much attention to this module. So I'm not overly concerned about using borp here. If it simplifies things, go for it.

I moved the tests to borp as done in avvio
I used the same patterns as used in the master branch with tap

I am worry the coverage is not checked anymore, can you please try with -C --check-coverage on your machine? What happen if you remove one of these tests?

coverage readded, removing some of them the coverage goes down

removing some of them the coverage goes down

Did the tests fail? If coverage is not 100% covered, it should be red.

Don't know if we should use the flag --check-coverage?

It does look ok, but I never used borp so...

I've added the check, now if the coverage goes down it fails

Copilot reviewed 20 out of 35 changed files in this pull request and generated no comments.

Files not reviewed (15)

.taprc: Language not supported
package.json: Language not supported
scripts/unit.js: Evaluated as low risk
test/commonjs/autohooks-disabled.js: Evaluated as low risk
scripts/unit-typescript-tsm.js: Evaluated as low risk
scripts/unit-typescript-esm.js: Evaluated as low risk
test/commonjs/autohooks-basic.js: Evaluated as low risk
test/commonjs/autohooks-cascade.js: Evaluated as low risk
.borp.yaml: Evaluated as low risk
test/commonjs/options.js: Evaluated as low risk
test/commonjs/non-plugin.js: Evaluated as low risk
test/commonjs/index-package.js: Evaluated as low risk
test/commonjs/deep.js: Evaluated as low risk
test/commonjs/graph-dependency.js: Evaluated as low risk
test/commonjs/autohooks-overwrite.js: Evaluated as low risk

Comments suppressed due to low confidence (2)

test/commonjs/cyclic.js:7

The description for the test suite should be 'Node test suite for cyclic dependency'.

describe('Node test suite for babel-node', function () {

test/commonjs/dependency.js:20

Declare the variable 'res' within each 'it' block to avoid potential issues with variable scope and reuse.

const res = await app.inject({ url: '/plugin-a' })

jean-michelet

Sorry, but we have integrated support for Node 23 native type stripping.
Can you fix the conflicts plz, than I will merge your PR.

.borp.yaml

SamSalvatico · 2025-01-31T08:56:16Z

Sorry, but we have integrated support for Node 23 native type stripping. Can you fix the conflicts plz, than I will merge your PR.

done, tested locally with 22 and 23

jean-michelet · 2025-01-31T10:19:45Z

Good job @SamSalvatico!

Thanx for your time.

SamSalvatico added 14 commits January 14, 2025 18:54

test: forceEsm from tap to node test runner

f45a705

test: updated test/typescript/basic.ts

1280440

test: updated test/commonjs/autohooks-basic.js

a754488

test: updated test/commonjs/autohooks-*.js

3a4c5d6

test: updated test/commonjs/babel-node.js and basic.js

ab32e9d

test: updated cyclic

19adc59

test: updated deep

e51ee0d

test: updated dependency

c0120d3

test: updated commonjs/error

e76d97c

test: updated graph-dependency

aba67ed

test: updated commonjs/index-package.js

3f67a45

test: updated commonjs/non-plugin.js

f8ffbd3

test: updated commonjs/options.js

88a1c72

test: updated commonjs/route-parametrs.js

a605644

SamSalvatico marked this pull request as ready for review January 17, 2025 18:18

jean-michelet reviewed Jan 17, 2025

View reviewed changes

test/commonjs/autohooks-basic.js Outdated Show resolved Hide resolved

test/commonjs/error.js Outdated Show resolved Hide resolved

test/typescript-esm/forceESM.ts Outdated Show resolved Hide resolved

SamSalvatico added 3 commits January 17, 2025 20:27

test: use promises in forceEsm

fe23056

test: removed assert if error after promises

f5740b7

test: removed nested suites

371acca

SamSalvatico added 4 commits January 18, 2025 18:44

test: updated issue 369

54bd5e8

test: updated issue 374

cf0c1d3

test: updated issue 376

71a6660

Merge branch 'master' into test/5555-move-to-node-test-runner

d6f90b3

chore: removed tap from package.json

c6c55c9

SamSalvatico added 2 commits January 20, 2025 15:48

test: added glob to make windows able to expand patterns

595b08d

test: try using fast-glob instead of glob

3eab5ae

SamSalvatico commented Jan 20, 2025

View reviewed changes

jean-michelet requested a review from climba03003 January 21, 2025 08:34

mcollina approved these changes Jan 23, 2025

View reviewed changes

jean-michelet approved these changes Jan 23, 2025

View reviewed changes

jean-michelet mentioned this pull request Jan 23, 2025

support native Node.js Typescript type-stripping #441

Closed

jean-michelet mentioned this pull request Jan 25, 2025

feat: support native type stripping for Node >= v23 #442

Merged

jsumners mentioned this pull request Jan 26, 2025

Test: #5555 - move to node test fastify/under-pressure#253

Open

4 tasks

jean-michelet reviewed Jan 26, 2025

View reviewed changes

scripts/unit.js Outdated Show resolved Hide resolved

jean-michelet reviewed Jan 26, 2025

View reviewed changes

SamSalvatico added 3 commits January 26, 2025 19:53

test: use borp instead of fast-glob script

66e6abd

test: readded coverage

50499b1

test: added check on code coverage

a4e5cb2

Fdawgs requested a review from Copilot January 29, 2025 14:01

Copilot AI reviewed Jan 29, 2025

View reviewed changes

jean-michelet reviewed Jan 31, 2025

View reviewed changes

.borp.yaml Outdated Show resolved Hide resolved

SamSalvatico added 2 commits January 31, 2025 09:41

chore: newline

34d752e

test: resolved conflicts

2418ee3

jean-michelet merged commit e4ae352 into fastify:master Jan 31, 2025
11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: #5555 - move to node test runner #440

test: #5555 - move to node test runner #440

SamSalvatico commented Jan 16, 2025

SamSalvatico commented Jan 17, 2025

jean-michelet commented Jan 17, 2025

SamSalvatico commented Jan 17, 2025

jean-michelet commented Jan 17, 2025

jean-michelet commented Jan 17, 2025

dancastillo commented Jan 17, 2025

climba03003 commented Jan 18, 2025

SamSalvatico commented Jan 20, 2025

SamSalvatico Jan 20, 2025 •

edited

Loading

jean-michelet Jan 21, 2025 •

edited

Loading

jsumners Jan 21, 2025

jean-michelet commented Jan 21, 2025

mcollina left a comment

jean-michelet commented Jan 23, 2025

jean-michelet commented Jan 24, 2025

jsumners commented Jan 24, 2025

jean-michelet commented Jan 24, 2025 •

edited

Loading

jean-michelet commented Jan 26, 2025

jean-michelet Jan 26, 2025

jsumners Jan 26, 2025

SamSalvatico Jan 26, 2025

jean-michelet Jan 26, 2025 •

edited

Loading

SamSalvatico Jan 27, 2025

jean-michelet Jan 27, 2025

jean-michelet Jan 27, 2025

jean-michelet Jan 27, 2025

SamSalvatico Jan 28, 2025

jean-michelet left a comment

SamSalvatico commented Jan 31, 2025

jean-michelet commented Jan 31, 2025

test: #5555 - move to node test runner #440

test: #5555 - move to node test runner #440

Conversation

SamSalvatico commented Jan 16, 2025

Checklist

SamSalvatico commented Jan 17, 2025

jean-michelet commented Jan 17, 2025

SamSalvatico commented Jan 17, 2025

jean-michelet commented Jan 17, 2025

jean-michelet commented Jan 17, 2025

dancastillo commented Jan 17, 2025

climba03003 commented Jan 18, 2025

SamSalvatico commented Jan 20, 2025

SamSalvatico Jan 20, 2025 • edited Loading

Choose a reason for hiding this comment

jean-michelet Jan 21, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jean-michelet commented Jan 21, 2025

mcollina left a comment

Choose a reason for hiding this comment

jean-michelet commented Jan 23, 2025

jean-michelet commented Jan 24, 2025

jsumners commented Jan 24, 2025

jean-michelet commented Jan 24, 2025 • edited Loading

jean-michelet commented Jan 26, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jean-michelet Jan 26, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jean-michelet left a comment

Choose a reason for hiding this comment

SamSalvatico commented Jan 31, 2025

jean-michelet commented Jan 31, 2025

SamSalvatico Jan 20, 2025 •

edited

Loading

jean-michelet Jan 21, 2025 •

edited

Loading

jean-michelet commented Jan 24, 2025 •

edited

Loading

jean-michelet Jan 26, 2025 •

edited

Loading