chore: migrate to node test runner #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fdawgs
requested changes
Jan 10, 2025
Fdawgs
approved these changes
Jan 10, 2025
|
Up for merging this one over the other two test runner PRs @dancastillo? 😄 |
gurgunday
approved these changes
Jan 12, 2025
| t.test('application/yaml -> yaml', t => { | ||
| t.plan(3) | ||
| fastify.inject({ | ||
| await t.test('application/yaml -> yaml', async t => { |
There was a problem hiding this comment.
Does this test imbrication really is necessary? Or can describe be leveraged?
There was a problem hiding this comment.
Describe can be used as well, but on other PRs people expressed some preferences on using just test
There was a problem hiding this comment.
Can you plz share this PR? I would like to read the discussion about it.
There was a problem hiding this comment.
Unfortunately I can't, it has been a while ago and I cannot retrieve it anymore
There was a problem hiding this comment.
Maybe @Fdawgs has any idea about it
3 tasks
jean-michelet
approved these changes
Jan 12, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct