Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: drop array items type checking #706

Merged
merged 1 commit into from
Apr 11, 2024
Merged

feat: drop array items type checking #706

merged 1 commit into from
Apr 11, 2024

Conversation

ivan-tymoshenko
Copy link
Member

This is a small breaking change so should be released with a Fastify v5.
Take a look at: #524

@mcollina @gurgunday What branch should I select to merge to? next?

@ivan-tymoshenko ivan-tymoshenko added the semver-major Issue or PR that should land as semver major label Apr 10, 2024
@github-actions GitHub Actions
Copy link

PR:

MASTER:

gurgunday
gurgunday approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

What branch should I select to merge to? next?

please merge to next, it should be up to date

@ivan-tymoshenko ivan-tymoshenko changed the base branch from master to next April 10, 2024 13:15
mcollina
mcollina approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 377288f into next Apr 11, 2024
23 checks passed
@gurgunday gurgunday deleted the drop-array-items-type-checking branch April 11, 2024 13:44
jsumners pushed a commit that referenced this pull request Jun 21, 2024
@ivan-tymoshenko @jsumners
feat: drop array items type checking (#706)
444ffa7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurgunday gurgunday gurgunday approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
semver-major Issue or PR that should land as semver major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivan-tymoshenko @mcollina @gurgunday