add algorithm-option, set default hash algorithm to sha256 #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by the latest csurf sec. vuln.
snyk writes regarding csurf:
https://snyk.io/blog/explaining-the-csurf-vulnerability-csrf-attacks-on-all-versions/
I personally think sha1 or sha256 or whatever does not make a big difference as csrf is actually shortlived so there is no time to crack it actually. But this PR adds anyway the algorithm option.
It sets sha256 as default hash algorithm. It would be a breaking change, but people could upgrade and set the algorithm back to sha1 if they still want to use sha1.
It this gets merged, there would be a follow up PR for the csrf-protection package.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct