Add AdonisJS #343
Merged
Add AdonisJS #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you remove Node v14, v16 and v18 from the list of envs we support? |
I am not sure if you are asking me to modify something in this PR or make another PR that removes the outdated Node.js version from CI. On a side note, if needed, I could send another PR to migrate from import assertion to import attribution. |
|
Small bump. 👋🏻 |
|
Sorry for the long delay, I have a long queue of GitHub notifications to manage. CI was bumped, so you should be able to rebase now. |
9104492 to
d25151a
Compare
|
No worries! PR has been rebased. 👍🏻 |
|
finally done! Sorry for the wait! |
1 similar comment
|
finally done! Sorry for the wait! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! 👋🏻
This PR adds AdonisJS Http server for benchmarking purpose.
I am not quite sure about some options in the
package.jsfile, like theextraparams.AdonisJS comes by default with middleware enabled for example.
Let me know if I need to make any modification. 👍🏻