workflows: extend the test range #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fdawgs
approved these changes
Apr 24, 2024
|
@gurgunday The engines field in package.json is |
|
Second, I think tap is failing at node 14 so I had to start from the lowest LTS version it currently supports |
Edit: we already did in next |
Ah, well good spot on that then! :D |
jsumners
pushed a commit
that referenced
this pull request
Jul 3, 2024
* test for lts from 14 to 20 * test from 16 * update
jsumners
added a commit
that referenced
this pull request
Jul 5, 2024
* update for Fastify v5 (#30) * update for v5 * add pre-commit * package-manager v4 * revert change * remove engines field * workflows: extend the test range (#32) * test for lts from 14 to 20 * test from 16 * update * update for Fastify v5 (#30) * update for v5 * add pre-commit * package-manager v4 * revert change * remove engines field * workflows: extend the test range (#32) * test for lts from 14 to 20 * test from 16 * update * update ci --------- Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't necessarily need to stop testing on older versions for libraries, we can just extend the test range using the new workflow