Does not work on local web pages in htmlz format

[kramola-RU]

Hi!
The addon does not work on local web pages saved with SingleFile (SingleFileZ).
Could you add the ability to work on saved local files?

[farblos]

I could reproduce your issue (not working on files saved with SingleFileZ) for the first time after I installed SingleFileZ.

After restarting the browser and opening a *.zip.html page copy-on-select somehow started working even on that previously saved page.

Will try again tomorrow with a fresh browser profile - if you have some more detailed instructions on how to reproduce the issue, pls let me know.

[kramola-RU]

if you have some more detailed instructions on how to reproduce the issue, pls let me know.

I open any file saved in SingleFileZ and the addon does not work.
I'm using Firefox 117a1

For example - this file:
https://www.upload.ee/files/15495391/example.7z.html

[farblos]

Thanks for the sample - I can reproduce the issue now. Will have a closer look tomorrow.

[farblos]

The good news: There is hope.

The bad news: It's a timing related issue - if I sleep 50ms before adding the main event listener things seem to work. Not beautiful.

Since you are on FF nightly and a GitHub user, would you mind testing an unsigned extension that provides this fix? I have pushed the tentative changes to branch "8-does-not-work-on-local-web-pages-in-htmlz-format". If you clone that branch you should be able to use that clone as temporary extension. Alternatively, I can provide an unsigned xpi.

If you need instructions on all that, just let me know. If that's all too much, also fine - only having such a hack asks for more tests, I think.

Thanks.

[kramola-RU]

I have pushed the tentative changes to branch "8-does-not-work-on-local-web-pages-in-htmlz-format".

Thank you very much!
This version works fine with .htmlz files.

[farblos]

Now that was quick - thanks as well for testing!

Will need some time to finalize the changes and test some more - stay tuned...

[farblos]

https://discourse.mozilla.org/t/addeventlistener-in-content-script-not-executed-effective-on-htmlz-pages/121436

[farblos]

Found the root cause of the issue, nothing funny or strange about this. The body of the document changes after it has been loaded, thus loosing the initially attached event listener. This isn't particularly difficult to fix, I just haven't had this on my radar before. In any case this will require a different/better fix.

[kramola-RU]

The body of the document changes after it has been loaded, thus loosing the initially attached event listener.

But some addons are not affected by this problem.
For example, Gesturefy and Drag-Select Link Text.

[farblos]

But some addons are not affected by this problem.
For example, Gesturefy and Drag-Select Link Text.

Most likely because they did this thing correctly right from the start :-)

After all, I started this fork because I needed this functionality myself and found the original extension a bit too limited. Now I keep learning more and more JavaScript with every bug a user comes across ...

So if you find any such issues in future, please do file them - very much appreciated!

I hope to have a final version fixing this issue ready by end of this weekend.

[kramola-RU]

I hope to have a final version fixing this issue ready by end of this weekend.

Super! I'll be happy to test that version.

[farblos]

Just released version 2.5. Please give it a try, when all is good I'll upload it to addons.mozilla.org.

[kramola-RU]

give it a try

2.5 works great. Brilliant! Thank you very much!
I have one question:
I want to disable restrictions for all websites.
Will it be enough to just remove these lines from the script?

// ignore events on some sites
if ( (new URL( document.URL )).hostname === "docs.google.com" )
  return;

let s = document.getSelection().toString();
let t = e.target;

Or do I need to remove some additional lines?

[farblos]

2.5 works great.

Thanks for testing, will upload to AMO soon.

Will it be enough to just remove these lines from the script?

You should only remove these three lines:

// ignore events on some sites
if ( (new URL( document.URL )).hostname === "docs.google.com" )
  return;

but leave the others in - the let statements are important for the rest and have nothing to do with the site restriction.

This restriction, by the way, comes from issue #1. The problem is that on docs.google.com this extension breaks regular copy and paste.

Closing this issue - if you have more questions, feel free to continue in the closed issue or open another one ...