Add frontend test suite #1
Conversation
There was a problem hiding this comment.
Thanks for the PR. I have two remarks on it:
- Please make sure that your PR works before requesting. You may use a draft PR for unfinished works.
- I'm not sure if I want to add webdriver-based tests in the current project state
While webdriver is useful for larger project to test UI, it also requires some considerations of how we structure our UI, since we need a proper way to find elements in DOM an acting with them. This may be okay, since one goal of this project is to learn more about technology. Maybe we need some more UI before activating webdriver. Maybe we should add some unit tests first.
.github/workflows/webdriver.yml
Outdated
| @@ -0,0 +1,77 @@ | |||
| # run this action when the repository is pushed to | |||
There was a problem hiding this comment.
Please make the workflow run successfully. In it's the current state, it fails.
webdriver/webdriverio/package.json
Outdated
| "dependencies": { | ||
| "@wdio/cli": "^7.34.0" | ||
| }, |
There was a problem hiding this comment.
This should be a test dependency. It is not needed during runtime. Please remove and re-add it using npm install --test.
| @@ -0,0 +1,32 @@ | |||
| // calculates the luma from a hex color `#abcdef` | |||
There was a problem hiding this comment.
This spec seems to be very generic and it will fail for our application. Please replace it with a useful first test for note.rs, e.g. you may test for the presence of title bar buttons are present or the transition from main to settings screen.
webdriver/webdriverio/wdio.conf.js
Outdated
| @@ -0,0 +1,293 @@ | |||
| exports.config = { | |||
There was a problem hiding this comment.
Please remove unnecessary boilerplate (most of the comments).
Adds the WebdriverIO test suite.
.github/workflows/webdriver.yml.webdriver/webdriverio/test/specs/example.e2e.jsare not adjusted to the current frontend but serve as an example.