Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: minor config improvements #1754

Merged
merged 3 commits into from
Jan 28, 2025
Merged

chore: minor config improvements #1754

merged 3 commits into from
Jan 28, 2025

Conversation

leogr
Copy link
Member

@leogr leogr commented Jan 22, 2025

Might address #1118
cc @FedeDP

leogr added 3 commits January 22, 2025 15:25
@leogr
fix(config): add missing reviewApprovedRequired
6b7fb3f 
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr
chore(config): align kernel-crawler config
79ada45 
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr
update(config/org.yaml): re-sync machine_users repos
6c2b8ef 
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@poiana poiana requested review from jonahjon and maxgio92 January 22, 2025 15:26
@FedeDP
Copy link
Contributor

FedeDP commented Jan 22, 2025

/hold

FedeDP
FedeDP approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Jan 28, 2025
@poiana
Copy link
Contributor

poiana commented Jan 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Contributor

FedeDP commented Jan 28, 2025

/unhold

@poiana poiana merged commit c227903 into master Jan 28, 2025
6 checks passed
@poiana poiana deleted the fix/misc-approved-label branch January 28, 2025 08:20
@poiana
Copy link
Contributor

poiana commented Jan 28, 2025

@leogr: Updated the following 2 configmaps:

  • config configmap in namespace default at cluster default using the following files:
    • key config.yaml using file config/config.yaml
  • plugins configmap in namespace default at cluster default using the following files:
    • key plugins.yaml using file config/plugins.yaml

In response to this:

Might address #1118
cc @FedeDP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedeDP FedeDP FedeDP approved these changes

@jonahjon jonahjon Awaiting requested review from jonahjon

@maxgio92 maxgio92 Awaiting requested review from maxgio92

Assignees

@FedeDP FedeDP

Labels
approved dco-signoff: yes lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leogr @FedeDP @poiana