-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(rules): bump engine version to Falco 0.37.0 engine version #218
update(rules): bump engine version to Falco 0.37.0 engine version #218
Conversation
Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
/hold |
/cc @loresuso |
Rules files suggestionsfalco_rules.yamlComparing Minor changes:
Patch changes:
falco-sandbox_rules.yamlComparing Patch changes:
falco-incubating_rules.yamlComparing Minor changes:
Patch changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
LGTM label has been added. Git tree hash: 57b89f0390a8068b4839dfdaa10e990c37be61e1
|
This change makes the rulesets incompatible with Falco 0.36 (that's fine anyway). Thus, this requires:
Note: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from my side!
@leogr perhaps we should add another badge "Compatible Falco Version" see the other readme update PR we are staging. |
Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
Done, we will need to add Falco 0.37.0 when released /unhold Could you please re-approve? |
Rules files suggestionsfalco_rules.yamlComparing Minor changes:
Patch changes:
falco-sandbox_rules.yamlComparing Patch changes:
falco-incubating_rules.yamlComparing Minor changes:
Patch changes:
|
LGTM label has been added. Git tree hash: b5ebc829f5399086949a65360321d4a1628067f7
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area rules
Proposed rule maturity level
/area maturity-stable
/area maturity-incubating
/area maturity-sandbox
/area maturity-deprecated
What this PR does / why we need it:
This bumps the engine version to Falco 0.37.0 engine version
Which issue(s) this PR fixes:
Special notes for your reviewer: