Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(cmake): update libelf repo location and revision #2226

Merged

Conversation

LucaGuerra
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind cleanup

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

Does this PR require a change in the driver versions?

No

What this PR does / why we need it:

See: falcosecurity/evolution#421 . Also, upgrade to latest upstream revision.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update(elftoolchain/libelf): update to r4073-0

Copy link

github-actions bot commented Jan 7, 2025

Perf diff from master - unit tests

     3.29%     +0.71%  [.] sinsp_thread_manager::find_thread
     3.25%     +0.51%  [.] sinsp_evt::load_params
     1.39%     +0.42%  [.] sinsp::fetch_next_event
     2.67%     +0.40%  [.] sinsp_thread_manager::get_thread_ref
     5.59%     +0.40%  [.] next_event_from_file
     2.40%     -0.37%  [.] is_conversion_needed
     1.03%     -0.28%  [.] sinsp_evt::get_direction
    10.73%     -0.26%  [.] sinsp_parser::reset
     0.77%     -0.26%  [.] scap_next
     1.85%     -0.26%  [.] next

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0242         +0.0242           147           150           147           150
BM_sinsp_split_median                                          +0.0227         +0.0227           146           150           146           150
BM_sinsp_split_stddev                                          -0.1172         -0.1168             1             1             1             1
BM_sinsp_split_cv                                              -0.1381         -0.1377             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0010         +0.0009            61            61            61            61
BM_sinsp_concatenate_paths_relative_path_median                +0.0009         +0.0009            61            61            61            61
BM_sinsp_concatenate_paths_relative_path_stddev                +0.1417         +0.1446             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    +0.1407         +0.1435             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0439         +0.0439            24            25            24            25
BM_sinsp_concatenate_paths_empty_path_median                   +0.0425         +0.0425            24            25            24            25
BM_sinsp_concatenate_paths_empty_path_stddev                   +1.2897         +1.2895             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +1.1935         +1.1932             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0419         -0.0419            66            64            66            64
BM_sinsp_concatenate_paths_absolute_path_median                -0.0570         -0.0570            67            63            67            63
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.3751         -0.3757             1             1             1             1
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.3477         -0.3484             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.0216         +0.0216           386           395           386           395
BM_sinsp_split_container_image_median                          +0.0196         +0.0196           387           395           387           395
BM_sinsp_split_container_image_stddev                          -0.0369         -0.0369             2             2             2             2
BM_sinsp_split_container_image_cv                              -0.0573         -0.0573             0             0             0             0

Signed-off-by: Luca Guerra <luca@guerra.sh>
@LucaGuerra LucaGuerra force-pushed the update/elftoolchain-falcosecurity branch from aeba0f3 to 8bcbc53 Compare January 7, 2025 16:56
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.44%. Comparing base (258b4b4) to head (8bcbc53).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2226   +/-   ##
=======================================
  Coverage   75.44%   75.44%           
=======================================
  Files         265      265           
  Lines       34057    34057           
  Branches     5801     5800    -1     
=======================================
+ Hits        25695    25696    +1     
+ Misses       8362     8361    -1     
Flag Coverage Δ
libsinsp 75.44% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jan 8, 2025

LGTM label has been added.

Git tree hash: 7c09de407593e48377d2e5fe1db2ed8d326e3e96

@FedeDP
Copy link
Contributor

FedeDP commented Jan 8, 2025

/milestone 0.20.0

@poiana
Copy link
Contributor

poiana commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added this to the 0.20.0 milestone Jan 8, 2025
@poiana poiana merged commit 385822d into falcosecurity:master Jan 8, 2025
47 of 49 checks passed
@LucaGuerra LucaGuerra deleted the update/elftoolchain-falcosecurity branch January 8, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

4 participants