feat(fal/auth): add support for Google Colab token retrieval #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-lain
reviewed
Jan 20, 2025
Comment on lines
+26
to
+34
| def is_google_colab() -> bool: | ||
| try: | ||
| from IPython import get_ipython | ||
|
|
||
| return "google.colab" in str(get_ipython()) | ||
| except ModuleNotFoundError: | ||
| return False | ||
| except NameError: | ||
| return False |
There was a problem hiding this comment.
something I did not test yet is if this works with google colab pro as well ? (same with the client)
due to some issues in my country I can't access colab pro
this is how huggingface_hub handles it in case of any issues
https://github.com/huggingface/huggingface_hub/blob/main/src/huggingface_hub/utils/_runtime.py#L296
There was a problem hiding this comment.
oh, interesting. I think I have access to Pro, so I'll try it out in a sec.
There was a problem hiding this comment.
Seems to be working fine in pro.
|
3.12 tests are hanging up, probably unrelated. Investigating. |
4489d56 to
c384c06
Compare
22ca9a4 to
8d992f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapting #377 to work with sdk as well.
Kudos @not-lain