This repository has been archived by the owner on Apr 8, 2024. It is now read-only.
feat(fal): add dbt 1.5 support #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d643200 to
728b937
Compare
mederka
approved these changes
May 12, 2023
projects/fal/integration_tests/projects/000_fal_run/fal_scripts/after.py
Show resolved
Hide resolved
| # fal-format Python models | ||
| generated_models = generate_python_dbt_models(parsed.project_dir, arg_vars) | ||
| generated_models = generate_python_dbt_models(parsed.project_dir, parsed.vars) |
There was a problem hiding this comment.
When are we dropping these?
There was a problem hiding this comment.
When are we dropping these?
Did not really underrstand the question.
I just introduced --vars support for fal run too (wanted to use vars for a different use and added it). But it's really not related to dbt 1.5
Comment on lines
+93
to
+96
| # HACK: issue in dbt-core 1.5.0 https://github.com/dbt-labs/dbt-core/issues/7465 | ||
| env_target_path = os.getenv("DBT_TARGET_PATH") | ||
| if env_target_path: | ||
| config.target_path = env_target_path |
There was a problem hiding this comment.
Will target changes require any action from current users that want to update to 1.5?
There was a problem hiding this comment.
With this change, it should just work no matter how the use it. The thing is that maybe for 1.5.1 we will need to release a new fix.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dbt-labs/dbt-core#7465 is making it hard to reliably know where to search for artifacts (e.g. run_results) so we are still using the deprecated target-path in dbt_project.yml for pytest and we may need to use it for integration tests
closes #846
closes FEA-1037