Update Faker::Australia to Faker::Locations::Australia #2869

keshavbiswa · 2023-12-13T08:54:13Z

Motivation / Background

As per the discussion in #2787

This PR updates Faker::Australia to Faker::Locations::Australia to keep it consistent with the directory modules.

Checklist

Before submitting the PR make sure the following are checked:

This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
Tests are added or updated if you fix a bug, refactor something, or add a feature.
Tests and Rubocop are passing before submitting your proposed changes.

If you're proposing a new generator:

Open an issue first for discussion before you write any code.
Double-check the existing generators documentation to make sure the new generator you want to add doesn't already exist.
You've reviewed and followed the Documentation guidelines.

thdaraujo

Thanks for working on this!

It would also be necessary to:

deprecate the previous module and also keep it working
change the documentation
add tests

Please take a look at #2858 as it's introducing a new way of renaming and deprecating generators.

This can only be merged after #2858.

Also take a look at the contribution guideline on deprecations:

faker/CONTRIBUTING.md

Line 133 in 0576cce

    
           To remove a generator or any other public method, deprecate them first. We use the [`Gem::Deprecate`](https://ruby-doc.org/stdlib-3.1.0/libdoc/rubygems/rdoc/Gem/Deprecate.html).

keshavbiswa · 2023-12-20T17:08:02Z

I see now, Thanks for the suggestions. I will make the neccessary changes 👍

keshavbiswa · 2024-01-27T03:56:01Z

Waiting for #2858 to be merged so I can make necessary changes and merge this.

stefannibrasil · 2024-02-25T21:03:42Z

Hi @keshavbiswa we've merged #2858.

keshavbiswa · 2024-02-26T05:42:15Z

Hi @keshavbiswa we've merged #2858.

Time to make changes!

Bumps [minitest](https://github.com/minitest/minitest) from 5.21.1 to 5.21.2. - [Changelog](https://github.com/minitest/minitest/blob/master/History.rdoc) - [Commits](minitest/minitest@v5.21.1...v5.21.2) --- updated-dependencies: - dependency-name: minitest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.59.0 to 1.60.2. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.59.0...v1.60.2) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add Kenya to supported countries * Add tests for locale * clan up pull request * Add landline telephone numbers and cell phone formats

Bumps [minitest](https://github.com/minitest/minitest) from 5.21.2 to 5.22.2. - [Changelog](https://github.com/minitest/minitest/blob/master/History.rdoc) - [Commits](minitest/minitest@v5.21.2...v5.22.2) --- updated-dependencies: - dependency-name: minitest dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [test-unit](https://github.com/test-unit/test-unit) from 3.6.1 to 3.6.2. - [Release notes](https://github.com/test-unit/test-unit/releases) - [Commits](test-unit/test-unit@3.6.1...3.6.2) --- updated-dependencies: - dependency-name: test-unit dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

… with other generator's naming convention. (faker-ruby#2858) * Deprecate IDNumber to IdNumber per issue#2787 * wip * Add a Faker::Deprecator module Co-authored-by: Thiago Araujo <thd.araujo@gmail.com> * Add more specs and improve warning message --------- Co-authored-by: jamal.mohamed <jamal.mohamed@covermymeds.com> Co-authored-by: Stefanni Brasil <stefannibrasil@gmail.com> Co-authored-by: Thiago Araujo <thd.araujo@gmail.com>

* Favor 'The Room' instead of 'Room' This commit will rename instances of room to the_room including the locales. Originally the `room.md` had a typo that referenced ::Room and not ::TheRoom which is also fixed here. Ref: - faker-ruby#2787 Co-authored-by: Jamal-A-Mohamed <jamalashur@gmail.com> Co-authored-by: Salvador <salvador.tena@scientist.com> * Fix/Deprecate FmaBrotherhood Generator This commit fixes the naming discrpencies with the FmaBrotherhood (now FullmetalAlchemistBrotherhood) class and its filename. This adds deprecation warnings for the old FmaBrotherhood class and also makes the new FullmetalAlchemistBrotherhood class. Fix: - faker-ruby#2853 * Refactor deprecation for `FmaBrotherhood` This commit will refactor the changes from `FmaBrotherhood` to `FullmetalAlchemistBrotherhood` and use `Faker::Deprecator`. --------- Co-authored-by: Jamal-A-Mohamed <jamalashur@gmail.com> Co-authored-by: Salvador <salvador.tena@scientist.com> Co-authored-by: Stefanni Brasil <stefannibrasil@gmail.com>

Bumps [i18n](https://github.com/ruby-i18n/i18n) from 1.14.1 to 1.14.4. - [Release notes](https://github.com/ruby-i18n/i18n/releases) - [Changelog](https://github.com/ruby-i18n/i18n/blob/master/CHANGELOG.md) - [Commits](ruby-i18n/i18n@v1.14.1...v1.14.4) --- updated-dependencies: - dependency-name: i18n dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.60.2 to 1.62.1. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.60.2...v1.62.1) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [yard](https://github.com/lsegal/yard) from 0.9.34 to 0.9.36. - [Release notes](https://github.com/lsegal/yard/releases) - [Changelog](https://github.com/lsegal/yard/blob/main/CHANGELOG.md) - [Commits](lsegal/yard@v0.9.34...v0.9.36) --- updated-dependencies: - dependency-name: yard dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

keshavbiswa · 2024-03-17T12:05:23Z

Updated the changes @thdaraujo

keshavbiswa · 2024-03-18T06:50:10Z

Forgot the documentation 🤦

stefannibrasil

Thank you @keshavbiswa left a couple of comments ⭐

README.md

test/faker/locations/test_faker_australia.rb

lib/faker/locations/australia.rb

stefannibrasil

Awesome, this is looking great! One final change to remove some extra spaces from a location and this is ready to go.

stefannibrasil · 2024-03-19T15:10:39Z

lib/faker/locations/australia.rb

+        #
+        # @faker.version next
+        def location
+          fetch('locations.australia.locations')


lib/locales/en/australia.yml

stefannibrasil · 2024-03-19T15:12:56Z

oh, I haven't heard from the author of this PR in a while so this one is up to be worked on next. It's similar to this one. Would you be interested in fixing this one as well? #2857 @keshavbiswa

keshavbiswa · 2024-03-19T15:13:53Z

oh, I haven't heard from the author of this PR in a while so this one is up to be worked on next. It's similar to this one. Would you be interested in fixing this one as well? #2857 @keshavbiswa

I'll create a new PR for it 👍

stefannibrasil

thanks!

The changes have been made and this is now good to go

update Faker::Australia to Faker::Locations::Australia

382e49b

thdaraujo previously requested changes Dec 19, 2023

View reviewed changes

thdaraujo added 🙏🏽 PR: Needs Further Updates 🙏🏽 PR: Needs Tests 🙏🏽 PR: Needs Documentation Deprecation labels Dec 19, 2023

Merge branch 'main' into keshav/update-australia-to-locations-australia

c54a349

bpleslie approved these changes Jan 26, 2024

View reviewed changes

dependabot bot and others added 13 commits March 17, 2024 17:32

Add Kenya to supported countries (faker-ruby#2871)

9e004ca

* Add Kenya to supported countries * Add tests for locale * clan up pull request * Add landline telephone numbers and cell phone formats

Remove duplicates in doc file (faker-ruby#2914)

ebd93ab

Deprecated Faker::Australia

8cb3f4f

Merge branch 'main' into keshav/update-australia-to-locations-australia

bdc58b2

keshavbiswa requested review from thdaraujo and bpleslie March 17, 2024 12:04

Added Docs for Australia

783b8a9

keshavbiswa added 2 commits March 18, 2024 21:58

Updated Readme to include Locations

7df8a08

Merge branch 'main' into keshav/update-australia-to-locations-australia

69d845f

stefannibrasil reviewed Mar 18, 2024

View reviewed changes

README.md Show resolved Hide resolved

test/faker/locations/test_faker_australia.rb Show resolved Hide resolved

lib/faker/locations/australia.rb Outdated Show resolved Hide resolved

keshavbiswa added 3 commits March 19, 2024 10:56

Updated locales path for australia

9d69731

updated test to differentiate deprecated methods

865bddf

Merge branch 'main' into keshav/update-australia-to-locations-australia

2c9ab80

keshavbiswa requested a review from stefannibrasil March 19, 2024 05:27

stefannibrasil reviewed Mar 19, 2024

View reviewed changes

Removed whitespaces from australia.yml

391399c

keshavbiswa requested a review from stefannibrasil March 19, 2024 15:22

stefannibrasil approved these changes Mar 19, 2024

View reviewed changes

stefannibrasil merged commit fcf41f1 into faker-ruby:main Mar 19, 2024
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Faker::Australia to Faker::Locations::Australia #2869

Update Faker::Australia to Faker::Locations::Australia #2869

keshavbiswa commented Dec 13, 2023

thdaraujo left a comment •

edited

Loading

keshavbiswa commented Dec 20, 2023

keshavbiswa commented Jan 27, 2024

stefannibrasil commented Feb 25, 2024

keshavbiswa commented Feb 26, 2024

keshavbiswa commented Mar 17, 2024

keshavbiswa commented Mar 18, 2024

stefannibrasil left a comment

stefannibrasil left a comment

stefannibrasil Mar 19, 2024

stefannibrasil commented Mar 19, 2024

keshavbiswa commented Mar 19, 2024

stefannibrasil left a comment

Update Faker::Australia to Faker::Locations::Australia #2869

Update Faker::Australia to Faker::Locations::Australia #2869

Conversation

keshavbiswa commented Dec 13, 2023

Motivation / Background

Checklist

thdaraujo left a comment • edited Loading

Choose a reason for hiding this comment

keshavbiswa commented Dec 20, 2023

keshavbiswa commented Jan 27, 2024

stefannibrasil commented Feb 25, 2024

keshavbiswa commented Feb 26, 2024

keshavbiswa commented Mar 17, 2024

keshavbiswa commented Mar 18, 2024

stefannibrasil left a comment

Choose a reason for hiding this comment

stefannibrasil left a comment

Choose a reason for hiding this comment

stefannibrasil Mar 19, 2024

Choose a reason for hiding this comment

stefannibrasil commented Mar 19, 2024

keshavbiswa commented Mar 19, 2024

stefannibrasil left a comment

Choose a reason for hiding this comment

thdaraujo left a comment •

edited

Loading