chore: define const of a type instead of type casting in generateLocales script

[pkuczynski]

This will start catching issues with our locales definitions...
Check #729 listing the issues...

[codecov]

Codecov Report

Merging #728 (2cf4c24) into main (a37b1ef) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #728   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files        1924     1924           
  Lines      177022   177022           
  Branches      904      904           
=======================================
  Hits       175861   175861           
  Misses       1105     1105           
  Partials       56       56           

[ST-DDT]

This will be in v7 at the earliest as it definitely a breaking change.

[pkuczynski]

How come this is a breaking change?

[ST-DDT]

How come this is a breaking change?

If we are strict about it, we loose like 20% of our locale data categories (Guestimated).
App, buisness, cell phone, team, ...

[ST-DDT]

And I would like to check each of them, whether they can be useful for us before deleting them.

[ST-DDT]

@pkuczynski I think we should change our definitions to be extensible like our base definitions:

faker/src/definitions/definitions.ts

Lines 54 to 58 in cc46a0c

	} & {
	// Unsupported & custom modules
	// eslint-disable-next-line @typescript-eslint/no-explicit-any
	[group: string]: any;
	};

That way we would get rid of the as X casts, while still allowing custom entries.
Do you want to create your own PR for it or do you want me to create it?
When that is merged, we can merge this one.

[ST-DDT]

Will be superseded by #915.

[pkuczynski]

Do you want to create your own PR for it or do you want me to create it? When that is merged, we can merge this one.

Go for it. I have super limited time at the moment :(

[ST-DDT]

Fixed in #915 .