Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add os. as street prefix for pl #640

Merged
merged 3 commits into from
Apr 5, 2022
Merged

feat: add os. as street prefix for pl #640

merged 3 commits into from
Apr 5, 2022

Conversation

krychaxp
Copy link
Contributor

Add street_prefix

@krychaxp
Update street_prefix.ts
274b01d 
Add street_prefix
@krychaxp krychaxp requested a review from a team as a code owner March 21, 2022 10:31
@ejcheng ejcheng added p: 1-normal Nothing urgent s: needs decision Needs team/maintainer decision c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs labels Mar 21, 2022
@ejcheng ejcheng added this to the v6.2 - New small features milestone Mar 21, 2022
@ejcheng ejcheng added c: feature Request for new feature and removed c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs labels Mar 21, 2022
@ST-DDT ST-DDT added s: accepted Accepted feature / Confirmed bug c: locale Permutes locale definitions and removed c: feature Request for new feature s: needs decision Needs team/maintainer decision labels Mar 21, 2022
@codecov
Copy link

codecov bot commented Mar 21, 2022 •
edited
Loading

Codecov Report

Merging #640 (a1820ff) into main (b04dc91) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head a1820ff differs from pull request most recent head 96fe80d. Consider uploading reports for the commit 96fe80d to get more accurate results

@@            Coverage Diff             @@
##             main     #640      +/-   ##
==========================================
- Coverage   99.34%   99.34%   -0.01%     
==========================================
  Files        1921     1921              
  Lines      176644   176539     -105     
  Branches      905      912       +7     
==========================================
- Hits       175491   175382     -109     
- Misses       1097     1101       +4     
  Partials       56       56
Impacted Files Coverage Δ
src/locales/pl/address/street_prefix.ts 100.00% <100.00%> (ø)
src/address.ts 99.09% <0.00%> (-0.72%) ⬇️
src/lorem.ts 100.00% <0.00%> (ø)
src/definitions/address.ts 100.00% <0.00%> (ø)
src/locales/ar/address/street_address.ts 100.00% <0.00%> (ø)
src/locales/az/address/street_address.ts 100.00% <0.00%> (ø)
src/locales/cz/address/street_address.ts 100.00% <0.00%> (ø)
src/locales/de/address/street_address.ts 100.00% <0.00%> (ø)
src/locales/en/address/street_address.ts 100.00% <0.00%> (ø)
src/locales/fr/address/street_address.ts 100.00% <0.00%> (ø)
... and 25 more

@Shinigami92 Shinigami92 changed the title Update street_prefix.ts feat: add os. as street prefix for pl Apr 5, 2022
@Shinigami92 Shinigami92 requested review from a team April 5, 2022 15:50
ST-DDT
ST-DDT approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format wise this looks good. Cannot check content wise.

@ST-DDT ST-DDT requested review from pkuczynski and a team April 5, 2022 16:46
pkuczynski
pkuczynski approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@pkuczynski pkuczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

os. is shortcut form osiedle == estate

@ST-DDT ST-DDT enabled auto-merge (squash) April 5, 2022 21:53
@ST-DDT ST-DDT merged commit c6d0cc7 into faker-js:main Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@pkuczynski pkuczynski pkuczynski approved these changes

Assignees
No one assigned
Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Milestone
v6.2 - New small features
Development

Successfully merging this pull request may close these issues.
5 participants
@krychaxp @pkuczynski @ST-DDT @Shinigami92 @ejcheng