Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix prisis github profile link #633

Merged
merged 1 commit into from
Mar 18, 2022
Merged

docs: fix prisis github profile link #633

merged 1 commit into from
Mar 18, 2022

Conversation

akbaruddin
Copy link
Contributor

No description provided.

@akbaruddin akbaruddin changed the title typo: prisis github user name ✏️ prisis github user name ✏️ Mar 18, 2022
@akbaruddin akbaruddin changed the title prisis github user name ✏️ fix: prisis github user name ✏️ Mar 18, 2022
@Shinigami92 Shinigami92 changed the title fix: prisis github user name ✏️ docs: fix prisis github profile link Mar 18, 2022
@Shinigami92 Shinigami92 added the c: docs Improvements or additions to documentation label Mar 18, 2022
@Shinigami92 Shinigami92 requested review from prisis and ST-DDT March 18, 2022 09:29
@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #633 (cfce8c7) into main (f679f50) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #633      +/-   ##
==========================================
- Coverage   99.33%   99.33%   -0.01%     
==========================================
  Files        1920     1920              
  Lines      176483   176483              
  Branches      907      905       -2     
==========================================
- Hits       175305   175303       -2     
- Misses       1122     1124       +2     
  Partials       56       56
Impacted Files Coverage Δ
src/vendor/unique.ts 93.54% <0.00%> (-1.62%) ⬇️

@ST-DDT ST-DDT added the p: 1-normal Nothing urgent label Mar 18, 2022
@Shinigami92 Shinigami92 merged commit 985c39c into faker-js:main Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@prisis prisis Awaiting requested review from prisis

Assignees

@akbaruddin akbaruddin

Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Milestone
v6.1 - First bugfixes
Development

Successfully merging this pull request may close these issues.
3 participants
@akbaruddin @ST-DDT @Shinigami92