-
-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(address.countryCode): signature #588
Merged
Shinigami92
merged 5 commits into
faker-js:main
from
xDivisionByZerox:fix/address-country-code-signature
Apr 5, 2022
Merged
refactor(address.countryCode): signature #588
Shinigami92
merged 5 commits into
faker-js:main
from
xDivisionByZerox:fix/address-country-code-signature
Apr 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #588 +/- ##
========================================
Coverage 99.34% 99.34%
========================================
Files 1921 1923 +2
Lines 176539 176869 +330
Branches 912 895 -17
========================================
+ Hits 175382 175718 +336
+ Misses 1101 1095 -6
Partials 56 56
|
ST-DDT
reviewed
Mar 1, 2022
ST-DDT
approved these changes
Mar 2, 2022
Shinigami92
added
p: 1-normal
Nothing urgent
c: refactor
PR that affects the runtime behavior, but doesn't add new features or fixes bugs
and removed
c: feature
Request for new feature
labels
Mar 15, 2022
ejcheng
approved these changes
Mar 26, 2022
xDivisionByZerox
changed the title
fix: address.countryCode signature
refactor(address.countryCode): signature
Mar 30, 2022
Closed
ST-DDT
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: refactor
PR that affects the runtime behavior, but doesn't add new features or fixes bugs
p: 1-normal
Nothing urgent
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #587