Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(address.countryCode): signature #588

Merged
merged 5 commits into from
Apr 5, 2022
Merged

refactor(address.countryCode): signature #588

merged 5 commits into from
Apr 5, 2022

Conversation

xDivisionByZerox
Copy link
Member

Fixes #587

@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #588 (db96bea) into main (6214425) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head db96bea differs from pull request most recent head b222a71. Consider uploading reports for the commit b222a71 to get more accurate results

@@           Coverage Diff            @@
##             main     #588    +/-   ##
========================================
  Coverage   99.34%   99.34%            
========================================
  Files        1921     1923     +2     
  Lines      176539   176869   +330     
  Branches      912      895    -17     
========================================
+ Hits       175382   175718   +336     
+ Misses       1101     1095     -6     
  Partials       56       56            
Impacted Files Coverage Δ
src/address.ts 99.81% <100.00%> (+0.71%) ⬆️
src/helpers.ts 99.12% <0.00%> (-0.16%) ⬇️
src/index.ts 94.87% <0.00%> (-0.13%) ⬇️
src/random.ts 99.44% <0.00%> (-0.03%) ⬇️
src/fake.ts 100.00% <0.00%> (ø)
src/word.ts 100.00% <0.00%> (ø)
src/faker.ts 100.00% <0.00%> (ø)
src/lorem.ts 100.00% <0.00%> (ø)
src/commerce.ts 100.00% <0.00%> (ø)
src/datatype.ts 100.00% <0.00%> (ø)
... and 39 more

src/address.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT added this to the v6.2 - New small features milestone Mar 1, 2022
@ST-DDT ST-DDT added the c: feature Request for new feature label Mar 1, 2022
@ST-DDT ST-DDT requested a review from a team March 2, 2022 07:22
@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs and removed c: feature Request for new feature labels Mar 15, 2022
@xDivisionByZerox xDivisionByZerox changed the title fix: address.countryCode signature refactor(address.countryCode): signature Mar 30, 2022
@ST-DDT ST-DDT mentioned this pull request Apr 3, 2022
@Shinigami92 Shinigami92 enabled auto-merge (squash) April 5, 2022 16:51
@Shinigami92 Shinigami92 merged commit ccb58a1 into faker-js:main Apr 5, 2022
@xDivisionByZerox xDivisionByZerox deleted the fix/address-country-code-signature branch April 15, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change address.countryCode method signature
4 participants