Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enable test to generate Number.MAX_SAFE_INTEGER #3393

Merged
merged 2 commits into from
Feb 9, 2025
Merged

test: enable test to generate Number.MAX_SAFE_INTEGER #3393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48e0d87
test: enable test to generate Number.MAX_SAFE_INTEGER
ST-DDT Feb 6, 2025
714db7e
Merge branch 'next' into test/number/return-max_safe_integer
ST-DDT Feb 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions test/modules/number.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,8 +710,7 @@ describe('number', () => {
expect(actual).toBe(0);
});

// TODO @ST-DDT 2023-10-12: This requires a randomizer with 53 bits of precision
it.todo('should be able to return MAX_SAFE_INTEGER', () => {
it('should be able to return MAX_SAFE_INTEGER', () => {
randomizer.next = () => MERSENNE_MAX_VALUE;
const actual = customFaker.number.int();
expect(actual).toBe(Number.MAX_SAFE_INTEGER);
Expand Down
2 changes: 1 addition & 1 deletion test/utils/mersenne-test-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ export const TWISTER_53CO_MAX_VALUE = 0.9999999999999999;
/**
* The maximum value that can be returned by `next()`.
*/
export const MERSENNE_MAX_VALUE = TWISTER_32CO_MAX_VALUE;
export const MERSENNE_MAX_VALUE = TWISTER_53CO_MAX_VALUE;