Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra(unicorn): prefer-string-slice #3247

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Nov 4, 2024

Ref: #2439

Previous failed PR: #2814


Permanently disables the unicorn/prefer-string-slice lint rule.

  • string.substring is sometimes easier to use than string.slice
  • string.slice is less known than string.substring

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Nov 4, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Nov 4, 2024
@ST-DDT ST-DDT self-assigned this Nov 4, 2024
@ST-DDT ST-DDT requested a review from a team as a code owner November 4, 2024 12:16
Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit bfed12a
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/672a0ba5025ba20008835fef
😎 Deploy Preview https://deploy-preview-3247.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (2ec9c47) to head (bfed12a).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3247      +/-   ##
==========================================
- Coverage   99.96%   99.95%   -0.02%     
==========================================
  Files        2805     2805              
  Lines      217098   217098              
  Branches      968      585     -383     
==========================================
- Hits       217018   216994      -24     
- Misses         80      104      +24     

see 1 file with indirect coverage changes

@ST-DDT ST-DDT requested a review from a team November 4, 2024 12:29
@ST-DDT ST-DDT enabled auto-merge (squash) November 5, 2024 12:12
@ST-DDT ST-DDT merged commit ae10d9a into next Nov 5, 2024
23 checks passed
@ST-DDT ST-DDT deleted the infra/unicorn/prefer-string-slice branch November 5, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants