-
-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: patch and filter seeded run stacktraces #3229
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3229 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 2805 2805
Lines 217070 217070
Branches 972 969 -3
=======================================
+ Hits 216997 217003 +6
+ Misses 73 67 -6 |
If you want to test this changes yourself, you can use this patch: t.describe('zipCode', (t) => {
t.it('noArgs')
.it('with string', '###')
- .it('with format option', { format: '###-###' });
+ .it('with format option', { format: '###-####' })
// TODO @Shinigami92 2024-03-15: These are currently commented out because non-default locales are currently not supported
- // .it('with state option', { state: 'CA' })
+ .it('with state option', { state: 'CA' });
// .it('with options', { state: 'CA', format: '###-###' }); |
Shinigami92
previously approved these changes
Oct 27, 2024
Shinigami92
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed during today's team-meeting:
This PR changes the error location shown by seeded runs.
I'm not sure about the actual stacktrace filtering. Should we only use the stacktrace expansion?
Preview
You can observe two differences in each image category:
Variants:
Error in Method
Old
Stacktrace Expansion
Stacktrace Expansion And Filtering
Snapshot-Diff:
Old
Stacktrace Expansion
Stacktrace Expansion And Filtering