Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gender): fixed gender typos #2808

Merged
merged 1 commit into from
Apr 12, 2024
Merged

chore(gender): fixed gender typos #2808

merged 1 commit into from
Apr 12, 2024

Conversation

bodiam
Copy link
Contributor

@bodiam bodiam commented Apr 12, 2024

In this PR, I've fixed a few typos related to genders.

@bodiam bodiam requested a review from a team as a code owner April 12, 2024 01:27
@netlify Netlify
Copy link

netlify bot commented Apr 12, 2024 •
edited
Loading

✅ Deploy Preview for fakerjs canceled.

Name Link
🔨 Latest commit dfb60ea
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66188defae5ccd0008d9a18c

@codecov Codecov
Copy link

codecov bot commented Apr 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (03b965a) to head (dfb60ea).

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #2808   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files        2971     2971           
  Lines      212619   212619           
  Branches      947      949    +2     
=======================================
+ Hits       212526   212531    +5     
+ Misses         93       88    -5
Files Coverage Δ
src/locales/en/person/gender.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT requested review from a team April 12, 2024 06:28
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: person Something is referring to the person module labels Apr 12, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Apr 12, 2024
@xDivisionByZerox xDivisionByZerox merged commit ecbe8c6 into faker-js:next Apr 12, 2024
23 checks passed
@xDivisionByZerox xDivisionByZerox added the c: chore PR that doesn't affect the runtime behavior label Apr 12, 2024
@bodiam bodiam deleted the gender-typo-fix branch April 12, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@matthewmayer matthewmayer matthewmayer approved these changes

Assignees

@bodiam bodiam

Labels
c: chore PR that doesn't affect the runtime behavior c: locale Permutes locale definitions m: person Something is referring to the person module p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging this pull request may close these issues.
4 participants
@bodiam @matthewmayer @ST-DDT @xDivisionByZerox