Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: prepare v9 migration guide #2805

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

matthewmayer
Copy link
Contributor

@matthewmayer matthewmayer commented Apr 11, 2024

alternative for #2788

concatenates the migration guide snippets. I tried to organize in a reasonably sensible order but didn't edit the content other than the headings.

EDIT: The merged page has been edited.

Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 96864f0
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/6618e39d10d3230008a2a2eb
😎 Deploy Preview https://deploy-preview-2805.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (ecbe8c6) to head (96864f0).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2805   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files        2971     2971           
  Lines      212619   212619           
  Branches      946      947    +1     
=======================================
+ Hits       212527   212532    +5     
+ Misses         92       87    -5     

see 2 files with indirect coverage changes

@Shinigami92 Shinigami92 added the s: needs decision Needs team/maintainer decision label Apr 11, 2024
@matthewmayer
Copy link
Contributor Author

matthewmayer commented Apr 11, 2024

Can you trigger the netlify deploy so we have an easy way to preview this?

@matthewmayer matthewmayer marked this pull request as ready for review April 11, 2024 12:26
@matthewmayer matthewmayer requested a review from a team as a code owner April 11, 2024 12:26
@matthewmayer matthewmayer added the c: docs Improvements or additions to documentation label Apr 11, 2024
@matthewmayer matthewmayer self-assigned this Apr 11, 2024
@matthewmayer matthewmayer added the p: 1-normal Nothing urgent label Apr 11, 2024
@Shinigami92
Copy link
Member

Can you trigger the netlify deploy so we have an easy way to preview this?

You mean this? https://deploy-preview-2805.fakerjs.dev/

@matthewmayer
Copy link
Contributor Author

Can you trigger the netlify deploy so we have an easy way to preview this?

You mean this? https://deploy-preview-2805.fakerjs.dev/

Thanks. https://deploy-preview-2805.fakerjs.dev/guide/upgrading.html

@ST-DDT
Copy link
Member

ST-DDT commented Apr 11, 2024

IMO the Remove deprecated locale aliases is at the wrong location and should be maybe in front of https://deploy-preview-2805.fakerjs.dev/guide/upgrading.html#locale-aliases

@xDivisionByZerox xDivisionByZerox requested review from a team April 11, 2024 17:16
@ST-DDT ST-DDT added this to the v9.0 milestone Apr 11, 2024
@ST-DDT ST-DDT removed the s: needs decision Needs team/maintainer decision label Apr 11, 2024
@xDivisionByZerox
Copy link
Member

@matthewmayer We applied some changes together in todays meeting. Please review them since we want to release an alpha version very soon.

@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Apr 11, 2024
@ST-DDT ST-DDT requested a review from a team April 11, 2024 17:19
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have suggestions, but nothing blocking
So we could do these changes in later iterations before doing an official release

@matthewmayer
Copy link
Contributor Author

Same, I have minor feedback but looks great for now.

@xDivisionByZerox xDivisionByZerox merged commit f35f8db into faker-js:next Apr 12, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants