-
-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: prepare v9 migration guide #2805
docs: prepare v9 migration guide #2805
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2805 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 2971 2971
Lines 212619 212619
Branches 946 947 +1
=======================================
+ Hits 212527 212532 +5
+ Misses 92 87 -5 |
Can you trigger the netlify deploy so we have an easy way to preview this? |
You mean this? https://deploy-preview-2805.fakerjs.dev/ |
Thanks. https://deploy-preview-2805.fakerjs.dev/guide/upgrading.html |
IMO the |
@matthewmayer We applied some changes together in todays meeting. Please review them since we want to release an alpha version very soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have suggestions, but nothing blocking
So we could do these changes in later iterations before doing an official release
Same, I have minor feedback but looks great for now. |
alternative for #2788
concatenates the migration guide snippets. I tried to organize in a reasonably sensible order but didn't edit the content other than the headings.
EDIT: The merged page has been edited.