-
-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency eslint to v9 #2798
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2798 +/- ##
========================================
Coverage 99.96% 99.96%
========================================
Files 2747 2747
Lines 226148 226148
Branches 940 588 -352
========================================
+ Hits 226068 226070 +2
+ Misses 80 78 -2 |
c663f98
to
56ad741
Compare
I would like to explore the new eslint v9 and migrate to FlatConfig, so if nobody else has something against that, I would like to "claim" this PR and address some of my time in the upcoming days for this |
92c3bfb
to
db4f46f
Compare
db4f46f
to
de40889
Compare
de40889
to
7ef362e
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
e0ed0a4
to
3605045
Compare
7dc2145
to
130504e
Compare
In the past eslint version (9.2 and 9.3) there were backwards compatibility introduced |
4a13134
to
068b373
Compare
What is the status of this PR? |
|
Small progress: Although it might not be enough yet. |
Please note that I also have a life and can't rush to immediately progress with this PR. Even when I already got notified about that plugin-progress. |
That was not my intention.
Sorry, it is a habit from work, where I document any related progress in the ticket itself, so that other readers of the ticket are aware of the status, without being subscribed to the related ticket. |
There was no "@" in the original message. I was happy to be notified about updates towards the progress of the issue. If you feel overwhelmed by messages in an issue/PR, please use githubs notification system to unsubscribe from notifications from them. |
I'm assigned and so also responsible for this issue When it is okay to not push other issues and PRs related to my responsibility, it is also okay if we can slow a little bit down with this issue and I can enjoy the last two days of my vacation |
068b373
to
0a1079b
Compare
Current output with Oops! Something went wrong! :(
ESLint: 9.4.0
TypeError: context.getAncestors is not a function
Occurred while linting D:\shinigami\OpenSource\faker\.prettierrc.d.ts:1
Rule: "deprecation/deprecation"
at getParent (D:\shinigami\OpenSource\faker\node_modules\.pnpm\eslint-plugin-deprecation@3.0.0_eslint@9.4.0_typescript@5.4.5\node_modules\eslint-plugin-deprecation\dist\rules\deprecation.js:86:31)
at isDeclaration (D:\shinigami\OpenSource\faker\node_modules\.pnpm\eslint-plugin-deprecation@3.0.0_eslint@9.4.0_typescript@5.4.5\node_modules\eslint-plugin-deprecation\dist\rules\deprecation.js:94:20)
at identifierRule (D:\shinigami\OpenSource\faker\node_modules\.pnpm\eslint-plugin-deprecation@3.0.0_eslint@9.4.0_typescript@5.4.5\node_modules\eslint-plugin-deprecation\dist\rules\deprecation.js:60:13)
at ruleErrorHandler (D:\shinigami\OpenSource\faker\node_modules\.pnpm\eslint@9.4.0\node_modules\eslint\lib\linter\linter.js:1115:48)
at D:\shinigami\OpenSource\faker\node_modules\.pnpm\eslint@9.4.0\node_modules\eslint\lib\linter\safe-emitter.js:45:58
at Array.forEach (<anonymous>)
at Object.emit (D:\shinigami\OpenSource\faker\node_modules\.pnpm\eslint@9.4.0\node_modules\eslint\lib\linter\safe-emitter.js:45:38)
at NodeEventGenerator.applySelector (D:\shinigami\OpenSource\faker\node_modules\.pnpm\eslint@9.4.0\node_modules\eslint\lib\linter\node-event-generator.js:297:26)
at NodeEventGenerator.applySelectors (D:\shinigami\OpenSource\faker\node_modules\.pnpm\eslint@9.4.0\node_modules\eslint\lib\linter\node-event-generator.js:326:22)
at NodeEventGenerator.enterNode (D:\shinigami\OpenSource\faker\node_modules\.pnpm\eslint@9.4.0\node_modules\eslint\lib\linter\node-event-generator.js:340:14)
ELIFECYCLE Command failed with exit code 2.
ERROR: "lint" exited with 2.
ELIFECYCLE Command failed with exit code 1. |
7e524ae
to
e31e788
Compare
This PR contains the following updates:
8.57.0
->9.0.0
Release Notes
eslint/eslint (eslint)
v9.0.0
Compare Source
Configuration
📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.