-
-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(person): delete set of invalid names in en_NG #2764
Conversation
These names don't seem legitimate
👷 Deploy request for fakerjs pending review.Visit the deploys page to approve it
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2764 +/- ##
==========================================
- Coverage 99.94% 99.93% -0.01%
==========================================
Files 2958 2958
Lines 213715 213713 -2
Branches 603 950 +347
==========================================
- Hits 213595 213583 -12
- Misses 120 130 +10
|
It seems these may be literal translations of Nigerian names in other languages eg eg Daluchi in Igbo https://www.legit.ng/ask-legit/quotes-messages/1501704-powerful-nigerian-names-meanings-fascinate-you/ but I couldn't find much evidence people use these translations in English. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me.
Hmm at some point this was a different list with fewer traditional English names |
If you look those up please also include the commit id that added/removed the other data. Then I can try to lookup the original PR that changed these. If @nbroad1881 confirms that the other names are fine/used in en_ng, then we can merge this. |
Merged in f694a2e Original PR discussion (as far as recoverable):
No more (recoverable) contributions or comments to FakerJs by prinx after that. |
These names don't seem legitimate