-
-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra(netlify): diff to next #2755
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2755 +/- ##
==========================================
- Coverage 99.93% 99.93% -0.01%
==========================================
Files 2958 2958
Lines 213715 213715
Branches 950 948 -2
==========================================
- Hits 213583 213568 -15
- Misses 132 143 +11
- Partials 0 4 +4 |
Alternatively, we could check for a Or maybe even a specific (empty) I would have to check that though if it does strange things with update to next though. |
KISS. If we need to change the process again, we can have a look if it's required. |
Currently, if you merge next into a PR, a build preview is created, even if the PR itself does not change anything docs related.
The new check uses next as a comparison base and uses a common ancestor comparison.
E.g. any changes on next in the meantime are ignored.
git diff next...some-branch
vsgit diff next some-branch
Unfortunately, this will refresh the preview for all commits in a PR that changes docs, not just those that affect the docs.
So more build-minutes spend on PRs that would change the docs. And no more build-minutes spend on PRs that don't change the docs.