Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(location)!: remove v8 deprecated location methods #2753

Merged
merged 6 commits into from
Mar 18, 2024
Merged

refactor(location)!: remove v8 deprecated location methods #2753

merged 6 commits into from
Mar 18, 2024

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs breaking change Cannot be merged when next version is not a major release m: location Something is referring to the location module labels Mar 15, 2024
@Shinigami92 Shinigami92 added this to the v9.0 milestone Mar 15, 2024
@Shinigami92 Shinigami92 self-assigned this Mar 15, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.93%. Comparing base (e624d0e) to head (26e9884).

Additional details and impacted files 
@@           Coverage Diff            @@
##             next    #2753    +/-   ##
========================================
  Coverage   99.93%   99.93%            
========================================
  Files        2958     2958            
  Lines      214375   213715   -660     
  Branches      963      599   -364     
========================================
- Hits       214234   213580   -654     
+ Misses        137      131     -6     
  Partials        4        4
Files Coverage Δ
src/modules/location/index.ts 99.67% <100.00%> (+0.61%) ⬆️

... and 2 files with indirect coverage changes

@Shinigami92 Shinigami92 marked this pull request as ready for review March 15, 2024 08:25
@Shinigami92 Shinigami92 requested a review from a team as a code owner March 15, 2024 08:25
@netlify Netlify
Copy link

netlify bot commented Mar 15, 2024 •
edited
Loading

✅ Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 26e9884
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/65f7ff464899810008f3467e
😎 Deploy Preview https://deploy-preview-2753.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Shinigami92 Shinigami92 requested review from xDivisionByZerox and a team March 17, 2024 09:43
@Shinigami92 Shinigami92 enabled auto-merge (squash) March 18, 2024 08:46
@Shinigami92 Shinigami92 merged commit 6dee178 into next Mar 18, 2024
20 checks passed
@ST-DDT ST-DDT deleted the remove-deprecated-location-methods branch April 17, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@matthewmayer matthewmayer matthewmayer approved these changes

@xDivisionByZerox xDivisionByZerox Awaiting requested review from xDivisionByZerox

Assignees

@Shinigami92 Shinigami92

Labels
breaking change Cannot be merged when next version is not a major release c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: location Something is referring to the location module p: 1-normal Nothing urgent
Projects
None yet
Milestone
v9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Shinigami92 @matthewmayer @ST-DDT @xDivisionByZerox