fix(commerce): return fractional prices

src/modules/commerce/index.ts

@@ -127,9 +127,9 @@ export class CommerceModule {
    * @param options.symbol The currency value to use. Defaults to `''`.
    *
    * @example
-   * faker.commerce.price() // 828.00
-   * faker.commerce.price({ min: 100 }) // 904.00
-   * faker.commerce.price({ min: 100, max: 200 }) // 154.00
+   * faker.commerce.price() // 828.07
+   * faker.commerce.price({ min: 100 }) // 904.15
+   * faker.commerce.price({ min: 100, max: 200 }) // 154.56
    * faker.commerce.price({ min: 100, max: 200, dec: 0 }) // 133
    * faker.commerce.price({ min: 100, max: 200, dec: 0, symbol: '$' }) // $114
    *
@@ -170,9 +170,9 @@ export class CommerceModule {
    * @param symbol The currency value to use. Defaults to `''`.
    *
    * @example
-   * faker.commerce.price() // 828.00
-   * faker.commerce.price(100) // 904.00
-   * faker.commerce.price(100, 200) // 154.00
+   * faker.commerce.price() // 828.07
+   * faker.commerce.price(100) // 904.15
+   * faker.commerce.price(100, 200) // 154.56
    * faker.commerce.price(100, 200, 0) // 133
    * faker.commerce.price(100, 200, 0, '$') // $114
    *
@@ -194,9 +194,9 @@ export class CommerceModule {
    * @param legacySymbol The currency value to use. This argument is deprecated. Defaults to `''`.
    *
    * @example
-   * faker.commerce.price() // 828.00
-   * faker.commerce.price({ min: 100 }) // 904.00
-   * faker.commerce.price({ min: 100, max: 200 }) // 154.00
+   * faker.commerce.price() // 828.07
+   * faker.commerce.price({ min: 100 }) // 904.15
+   * faker.commerce.price({ min: 100, max: 200 }) // 154.56
    * faker.commerce.price({ min: 100, max: 200, dec: 0 }) // 133
    * faker.commerce.price({ min: 100, max: 200, dec: 0, symbol: '$' }) // $114
    *
@@ -228,9 +228,9 @@ export class CommerceModule {
    * @param legacySymbol The currency value to use. This argument is deprecated. Defaults to `''`.
    *
    * @example
-   * faker.commerce.price() // 828.00
-   * faker.commerce.price({ min: 100 }) // 904.00
-   * faker.commerce.price({ min: 100, max: 200 }) // 154.00
+   * faker.commerce.price() // 828.07
+   * faker.commerce.price({ min: 100 }) // 904.15
+   * faker.commerce.price({ min: 100, max: 200 }) // 154.56
    * faker.commerce.price({ min: 100, max: 200, dec: 0 }) // 133
    * faker.commerce.price({ min: 100, max: 200, dec: 0, symbol: '$' }) // $114
    *
@@ -270,10 +270,32 @@ export class CommerceModule {
       return `${symbol}${0.0}`;
     }
 
-    // TODO @Shinigami92 2022-11-24: https://github.com/faker-js/faker/issues/350
-    const randValue = this.faker.number.int({ min, max });
+    if (min === max) {
+      return `${symbol}${min.toFixed(dec)}`;
+    }
+
+    const randValue = this.faker.number.float({
+      min,
+      max,
+      precision: (1 / 10) ** dec,
+    });
+
+    if (dec === 0) {
+      return `${symbol}${randValue.toFixed(dec)}`;
+    }
+
+    const randValueString = randValue.toFixed(dec).toString();
+    const lastDigit = this.faker.helpers.weightedArrayElement([
+      { weight: 5, value: '9' },
+      { weight: 3, value: '5' },
+      { weight: 1, value: '0' },
+      {
+        weight: 1,
+        value: this.faker.number.int({ min: 0, max: 9 }).toString(),
+      },
+    ]);
 
-    return symbol + randValue.toFixed(dec);
+    return `${symbol}${randValueString.replace(/\d$/, lastDigit)}`;
   }
 
   /**

test/modules/__snapshots__/commerce.spec.ts.snap

@@ -12,27 +12,27 @@ exports[`commerce > 42 > isbn > with variant 10 and space separators 1`] = `"0 7
 
 exports[`commerce > 42 > isbn > with variant 13 1`] = `"978-0-7917-7551-6"`;
 
-exports[`commerce > 42 > price > noArgs 1`] = `"375.00"`;
+exports[`commerce > 42 > price > noArgs 1`] = `"375.17"`;
 
-exports[`commerce > 42 > price > with max 1`] = `"375.00"`;
+exports[`commerce > 42 > price > with max 1`] = `"375.17"`;
 
-exports[`commerce > 42 > price > with max option 1`] = `"501.00"`;
+exports[`commerce > 42 > price > with max option 1`] = `"501.37"`;
 
-exports[`commerce > 42 > price > with min 1`] = `"406.00"`;
+exports[`commerce > 42 > price > with min 1`] = `"405.87"`;
 
-exports[`commerce > 42 > price > with min and max 1`] = `"69.00"`;
+exports[`commerce > 42 > price > with min and max 1`] = `"68.77"`;
 
-exports[`commerce > 42 > price > with min and max and decimals 1`] = `"69.0000"`;
+exports[`commerce > 42 > price > with min and max and decimals 1`] = `"68.7277"`;
 
-exports[`commerce > 42 > price > with min and max and decimals and symbol 1`] = `"$69.0000"`;
+exports[`commerce > 42 > price > with min and max and decimals and symbol 1`] = `"$68.7277"`;
 
-exports[`commerce > 42 > price > with min and max and decimals and symbol option 1`] = `"$69.0000"`;
+exports[`commerce > 42 > price > with min and max and decimals and symbol option 1`] = `"$68.7277"`;
 
-exports[`commerce > 42 > price > with min and max and decimals option 1`] = `"69.0000"`;
+exports[`commerce > 42 > price > with min and max and decimals option 1`] = `"68.7277"`;
 
-exports[`commerce > 42 > price > with min and max option 1`] = `"69.00"`;
+exports[`commerce > 42 > price > with min and max option 1`] = `"68.77"`;
 
-exports[`commerce > 42 > price > with min option 1`] = `"401.00"`;
+exports[`commerce > 42 > price > with min option 1`] = `"400.87"`;
 
 exports[`commerce > 42 > product 1`] = `"Pants"`;
 
@@ -56,27 +56,27 @@ exports[`commerce > 1211 > isbn > with variant 10 and space separators 1`] = `"1
 
 exports[`commerce > 1211 > isbn > with variant 13 1`] = `"978-1-4872-1906-2"`;
 
-exports[`commerce > 1211 > price > noArgs 1`] = `"929.00"`;
+exports[`commerce > 1211 > price > noArgs 1`] = `"928.50"`;
 
-exports[`commerce > 1211 > price > with max 1`] = `"929.00"`;
+exports[`commerce > 1211 > price > with max 1`] = `"928.50"`;
 
-exports[`commerce > 1211 > price > with max option 1`] = `"1242.00"`;
+exports[`commerce > 1211 > price > with max option 1`] = `"1241.50"`;
 
-exports[`commerce > 1211 > price > with min 1`] = `"933.00"`;
+exports[`commerce > 1211 > price > with min 1`] = `"932.00"`;
 
-exports[`commerce > 1211 > price > with min and max 1`] = `"97.00"`;
+exports[`commerce > 1211 > price > with min and max 1`] = `"96.40"`;
 
-exports[`commerce > 1211 > price > with min and max and decimals 1`] = `"97.0000"`;
+exports[`commerce > 1211 > price > with min and max and decimals 1`] = `"96.4260"`;
 
-exports[`commerce > 1211 > price > with min and max and decimals and symbol 1`] = `"$97.0000"`;
+exports[`commerce > 1211 > price > with min and max and decimals and symbol 1`] = `"$96.4260"`;
 
-exports[`commerce > 1211 > price > with min and max and decimals and symbol option 1`] = `"$97.0000"`;
+exports[`commerce > 1211 > price > with min and max and decimals and symbol option 1`] = `"$96.4260"`;
 
-exports[`commerce > 1211 > price > with min and max and decimals option 1`] = `"97.0000"`;
+exports[`commerce > 1211 > price > with min and max and decimals option 1`] = `"96.4260"`;
 
-exports[`commerce > 1211 > price > with min and max option 1`] = `"97.00"`;
+exports[`commerce > 1211 > price > with min and max option 1`] = `"96.40"`;
 
-exports[`commerce > 1211 > price > with min option 1`] = `"932.00"`;
+exports[`commerce > 1211 > price > with min option 1`] = `"931.50"`;
 
 exports[`commerce > 1211 > product 1`] = `"Sausages"`;
 
@@ -100,27 +100,27 @@ exports[`commerce > 1337 > isbn > with variant 10 and space separators 1`] = `"0
 
 exports[`commerce > 1337 > isbn > with variant 13 1`] = `"978-0-512-25403-0"`;
 
-exports[`commerce > 1337 > price > noArgs 1`] = `"263.00"`;
+exports[`commerce > 1337 > price > noArgs 1`] = `"262.79"`;
 
-exports[`commerce > 1337 > price > with max 1`] = `"263.00"`;
+exports[`commerce > 1337 > price > with max 1`] = `"262.79"`;
 
-exports[`commerce > 1337 > price > with max option 1`] = `"351.00"`;
+exports[`commerce > 1337 > price > with max option 1`] = `"351.09"`;
 
-exports[`commerce > 1337 > price > with min 1`] = `"299.00"`;
+exports[`commerce > 1337 > price > with min 1`] = `"298.99"`;
 
-exports[`commerce > 1337 > price > with min and max 1`] = `"63.00"`;
+exports[`commerce > 1337 > price > with min and max 1`] = `"63.19"`;
 
-exports[`commerce > 1337 > price > with min and max and decimals 1`] = `"63.0000"`;
+exports[`commerce > 1337 > price > with min and max and decimals 1`] = `"63.1019"`;
 
-exports[`commerce > 1337 > price > with min and max and decimals and symbol 1`] = `"$63.0000"`;
+exports[`commerce > 1337 > price > with min and max and decimals and symbol 1`] = `"$63.1019"`;
 
-exports[`commerce > 1337 > price > with min and max and decimals and symbol option 1`] = `"$63.0000"`;
+exports[`commerce > 1337 > price > with min and max and decimals and symbol option 1`] = `"$63.1019"`;
 
-exports[`commerce > 1337 > price > with min and max and decimals option 1`] = `"63.0000"`;
+exports[`commerce > 1337 > price > with min and max and decimals option 1`] = `"63.1019"`;
 
-exports[`commerce > 1337 > price > with min and max option 1`] = `"63.00"`;
+exports[`commerce > 1337 > price > with min and max option 1`] = `"63.19"`;
 
-exports[`commerce > 1337 > price > with min option 1`] = `"293.00"`;
+exports[`commerce > 1337 > price > with min option 1`] = `"293.09"`;
 
 exports[`commerce > 1337 > product 1`] = `"Ball"`;
 

test/modules/commerce.spec.ts

@@ -124,14 +124,14 @@ describe('commerce', () => {
           const price = faker.commerce.price(100, 100, 1);
 
           expect(price).toBeTruthy();
-          expect(price, 'the price should be equal 100.0').toBe('100.0');
+          expect(price, 'the price should equal 100.0').toBe('100.0');
         });
 
         it('should handle argument dec = 0', () => {
           const price = faker.commerce.price(100, 100, 0);
 
           expect(price).toBeTruthy();
-          expect(price, 'the price should be equal 100').toBe('100');
+          expect(price, 'the price should equal 100').toBe('100');
         });
       });