-
-
Notifications
You must be signed in to change notification settings - Fork 941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: check and improve handling of duplicate tags #2444
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2444 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 2805 2805
Lines 250168 250168
Branches 1106 1107 +1
=======================================
+ Hits 249118 249120 +2
+ Misses 1022 1020 -2
Partials 28 28
|
This is a behavior change no? The default for join is , |
Technically yes. Practically not, because we only ever have one. |
If we did have more than one should that throw an error? |
Changed. It looks like there was one method with two |
This PR should probably be renamed now then |
The title is already very long so appending it might be hard. |
Split the changes about allowing one one of each tag to a seperate PR? |
IMO this only does a single thing, what should I split here? I renamed it to reflect its doc impact |
This end up with nothing related to
|
True. Enabling the rule in this PR is kind of missleading. |
Ref: #2439Check eslint-plugin-unicorn rules to enable/configure/disable #2439Preparation work for enableing the
unicorn/require-array-join-separator
lint rule.