-
-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(locale): add da person category #2331
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2331 +/- ##
========================================
Coverage 99.60% 99.61%
========================================
Files 2721 2735 +14
Lines 248549 248991 +442
Branches 1082 1090 +8
========================================
+ Hits 247569 248032 +463
+ Misses 953 932 -21
Partials 27 27
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Hi Matt, Maybe I'm missing something, but could you explain a bit what kind of change you want me to do before this pull request is ready for merge? |
Sorry didn't see it was still blocking. Approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR title is misleading
You did not add a category to person, you added new data for person in da locale
So please adjust the PR title before merging, but then we are good to go
No description provided.