Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(image): add seeded tests for dataUri #2317

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Aug 14, 2023

The faker.image.dataUri method doesn't have seeded tests.
This PR adds them.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: test m: image Something is referring to the image module labels Aug 14, 2023
@ST-DDT ST-DDT requested review from a team August 14, 2023 11:06
@ST-DDT ST-DDT self-assigned this Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #2317 (a92b68b) into next (68f3ac4) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2317   +/-   ##
=======================================
  Coverage   99.59%   99.60%           
=======================================
  Files        2644     2644           
  Lines      245617   245617           
  Branches     1080     1086    +6     
=======================================
+ Hits       244626   244640   +14     
+ Misses        964      950   -14     
  Partials       27       27           

see 2 files with indirect coverage changes

@ST-DDT ST-DDT enabled auto-merge (squash) August 17, 2023 17:41
@ST-DDT ST-DDT merged commit b468d5f into next Aug 17, 2023
@ST-DDT ST-DDT deleted the test/image/dataUri/seeded-tests branch August 17, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: test m: image Something is referring to the image module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants