Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(number): remove wrong default value for float precision #2299

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

mshima
Copy link
Contributor

@mshima mshima commented Aug 7, 2023

No description provided.

@mshima mshima requested a review from a team as a code owner August 7, 2023 11:10
@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Aug 7, 2023
@ST-DDT ST-DDT changed the title docs: remove wrong default value for precision. docs(number): remove wrong default value for float precision Aug 7, 2023
@ST-DDT ST-DDT added the m: number Something is referring to the number module label Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #2299 (8de8927) into next (0a6e6ef) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2299      +/-   ##
==========================================
- Coverage   99.60%   99.59%   -0.01%     
==========================================
  Files        2644     2644              
  Lines      245772   245770       -2     
  Branches     1086     1082       -4     
==========================================
- Hits       244803   244779      -24     
- Misses        942      964      +22     
  Partials       27       27              
Files Changed Coverage Δ
src/modules/number/index.ts 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

@ST-DDT ST-DDT requested review from a team August 7, 2023 13:29
@ST-DDT ST-DDT merged commit 7f0daf3 into faker-js:next Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation m: number Something is referring to the number module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants