-
-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: use managed pnpm #2124
infra: use managed pnpm #2124
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2124 +/- ##
=======================================
Coverage 99.59% 99.59%
=======================================
Files 2605 2605
Lines 244951 244951
Branches 1252 1251 -1
=======================================
+ Hits 243956 243963 +7
+ Misses 968 961 -7
Partials 27 27 |
This should still stay? faker/.github/workflows/ci.yml Lines 39 to 43 in 744b80f
|
exactly, this is to make node v14 support working, because node v14 needs pnpm v7 this will be removed in #2121 |
Instead of pinning the pnpm version, use the given pnpm version set in package.json
Example of that it works: https://github.com/faker-js/faker/actions/runs/4871503438/jobs/8688541770#step:4:16