Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: use managed pnpm #2124

Merged
merged 2 commits into from
May 4, 2023
Merged

infra: use managed pnpm #2124

merged 2 commits into from
May 4, 2023

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented May 3, 2023

Instead of pinning the pnpm version, use the given pnpm version set in package.json

Example of that it works: https://github.com/faker-js/faker/actions/runs/4871503438/jobs/8688541770#step:4:16

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels May 3, 2023
@Shinigami92 Shinigami92 self-assigned this May 3, 2023
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #2124 (a35e3b7) into next (d9ec87e) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2124   +/-   ##
=======================================
  Coverage   99.59%   99.59%           
=======================================
  Files        2605     2605           
  Lines      244951   244951           
  Branches     1252     1251    -1     
=======================================
+ Hits       243956   243963    +7     
+ Misses        968      961    -7     
  Partials       27       27           

see 2 files with indirect coverage changes

@Shinigami92 Shinigami92 marked this pull request as ready for review May 3, 2023 12:05
@Shinigami92 Shinigami92 requested a review from a team as a code owner May 3, 2023 12:05
@ST-DDT ST-DDT requested review from a team May 3, 2023 12:47
@xDivisionByZerox
Copy link
Member

This should still stay?

- name: Install pnpm (node 14, pnpm 7)
if: matrix.node_version == 14
uses: pnpm/action-setup@v2.2.4
with:
version: 7

@Shinigami92
Copy link
Member Author

This should still stay?

- name: Install pnpm (node 14, pnpm 7)
if: matrix.node_version == 14
uses: pnpm/action-setup@v2.2.4
with:
version: 7

exactly, this is to make node v14 support working, because node v14 needs pnpm v7

this will be removed in #2121

@Shinigami92 Shinigami92 enabled auto-merge (squash) May 4, 2023 05:56
@Shinigami92 Shinigami92 merged commit 0740aa0 into next May 4, 2023
@Shinigami92 Shinigami92 deleted the ci-use-managed-pnpm branch May 15, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants